Why is get_cheapest_parallel_safe_total_inner() in pathkeys.c?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Why is get_cheapest_parallel_safe_total_inner() in pathkeys.c?

David Rowley-3
This probably ended up here because there's a bunch of other functions
named get_cheapest* in that file, but all of those relate to getting a
path for specific PathKeys. get_cheapest_parallel_safe_total_inner()
does not do that.

Maybe allpaths.c is a better home for it?

It seems to have been added in [1]

[1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=a71f10189dc10a2fe422158a2c9409e0f77c6b9e

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services


--
Sent via pgsql-hackers mailing list ([hidden email])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Why is get_cheapest_parallel_safe_total_inner() in pathkeys.c?

Robert Haas
On Fri, Apr 21, 2017 at 12:10 PM, David Rowley
<[hidden email]> wrote:
> This probably ended up here because there's a bunch of other functions
> named get_cheapest* in that file, but all of those relate to getting a
> path for specific PathKeys. get_cheapest_parallel_safe_total_inner()
> does not do that.

Yes, I just put it near to the code from which it was derived.

> Maybe allpaths.c is a better home for it?

I will let others be the judge of that.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Sent via pgsql-hackers mailing list ([hidden email])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers
Previous Thread Next Thread
Loading...