Quantcast

[pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

Murtuza Zabuawala
Hi,

Please find the patch to fix the issue while using ANALYZE option in IE.

Issue:
We were using .startsWith() function to check the sql if it is already starts with explain clause or not, which was added in commit: c758920890309e50f47a9427039cf735ddf04d37

But IE do not support .startsWith() function.


FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
Basic support4117 (17)(Yes)No support289


But IE do not support .startsWith() function.

I have also changed the code for File Manager module as well for the same issue.

So affected modules are,
- Query tool
- File Manager

Please review.
RM#2347


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list ([hidden email])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers

RM_2347.diff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

Dave Page-7
Akshay, can you review/commit this please?

On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

Please find the patch to fix the issue while using ANALYZE option in IE.

Issue:
We were using .startsWith() function to check the sql if it is already starts with explain clause or not, which was added in commit: c758920890309e50f47a9427039cf735ddf04d37

But IE do not support .startsWith() function.


FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
Basic support4117 (17)(Yes)No support289


But IE do not support .startsWith() function.

I have also changed the code for File Manager module as well for the same issue.

So affected modules are,
- Query tool
- File Manager

Please review.
RM#2347


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list ([hidden email])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [pgAdmin4][PATCH] To fix the issue of EXPLAIN option with IE

Akshay Joshi
Thanks patch applied.

On Mon, Apr 24, 2017 at 4:40 PM, Dave Page <[hidden email]> wrote:
Akshay, can you review/commit this please?

On Fri, Apr 21, 2017 at 10:25 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

Please find the patch to fix the issue while using ANALYZE option in IE.

Issue:
We were using .startsWith() function to check the sql if it is already starts with explain clause or not, which was added in commit: c758920890309e50f47a9427039cf735ddf04d37

But IE do not support .startsWith() function.


FeatureChromeFirefox (Gecko)EdgeInternet ExplorerOperaSafari
Basic support4117 (17)(Yes)No support289


But IE do not support .startsWith() function.

I have also changed the code for File Manager module as well for the same issue.

So affected modules are,
- Query tool
- File Manager

Please review.
RM#2347


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Sent via pgadmin-hackers mailing list ([hidden email])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Akshay Joshi
Principal Software Engineer 


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246
Previous Thread Next Thread
Loading...