[pgAdmin4][Patch]: To make error message uniform for Create schema action

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][Patch]: To make error message uniform for Create schema action

Murtuza Zabuawala
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_2094.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

Dave Page-7


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

Murtuza Zabuawala
Hi,

PFA updated.

On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <[hidden email]> wrote:


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.
​That's coming from ajax statusText, I thought it was intended.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_2094_v1.diff (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch]: To make error message uniform for Create schema action

Dave Page-7
Thanks, applied.

On Fri, Nov 17, 2017 at 10:30 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA updated.

On Thu, Nov 16, 2017 at 5:12 PM, Dave Page <[hidden email]> wrote:


On Tue, Nov 14, 2017 at 5:56 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to make error message uniform for 'Create schema' in both query tool and create schema dialog.
RM#2094

The error message is definitely an improvement, but the dialogue title needs work:

Error saving properties: GONE

Why does it have : GONE on the end? That seems unhelpful.
​That's coming from ajax statusText, I thought it was intended.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Previous Thread Next Thread