[pgAdmin4][RM#3140] Add service parameter

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
14 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][RM#3140] Add service parameter

Murtuza Zabuawala
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

Please review.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_3140.diff (352K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Dave Page-7
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Murtuza Zabuawala
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Murtuza Zabuawala
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



RM_3140_v1.diff (383K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Dave Page-7
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Joao De Almeida Pereira
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

refactor-javascript.diff (27K) Download Attachment
revert-upgrade-of-jasmine.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Dave Page-7
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Ashesh Vashi
Murtuza/Dave,

I have to reviewed/seen the patch yet.
But - I have a question.
Have we used the service file in the external tools for backup, restore, and import/export functionalities?
If not - we should fix that asap.

We had missed that during SSL support, and now - we're fixing that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Murtuza Zabuawala
Hi Ashesh,

I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi <[hidden email]> wrote:
Murtuza/Dave,

I have to reviewed/seen the patch yet.
But - I have a question.
Have we used the service file in the external tools for backup, restore, and import/export functionalities?
If not - we should fix that asap.

We had missed that during SSL support, and now - we're fixing that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Ashesh Vashi


On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Ashesh,

I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well.
No - that's a bad practice.
You need to work on full feature set, not partial.

If you have intentionally skipped that, you should have informed the list.

-- Thanks, Ashesh 


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi <[hidden email]> wrote:
Murtuza/Dave,

I have to reviewed/seen the patch yet.
But - I have a question.
Have we used the service file in the external tools for backup, restore, and import/export functionalities?
If not - we should fix that asap.

We had missed that during SSL support, and now - we're fixing that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Murtuza Zabuawala


On Tue, Mar 13, 2018 at 9:45 AM, Ashesh Vashi <[hidden email]> wrote:


On Tue, Mar 13, 2018 at 9:42 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Ashesh,

I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well.
No - that's a bad practice.
You need to work on full feature set, not partial.

If you have intentionally skipped that, you should have informed the list.

​I forgot to create sub-task, will keep that in mind next time onwards.​
https://redmine.postgresql.org/issues/3195
 

-- Thanks, Ashesh 


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Tue, Mar 13, 2018 at 9:01 AM, Ashesh Vashi <[hidden email]> wrote:
Murtuza/Dave,

I have to reviewed/seen the patch yet.
But - I have a question.
Have we used the service file in the external tools for backup, restore, and import/export functionalities?
If not - we should fix that asap.

We had missed that during SSL support, and now - we're fixing that.

--

Thanks & Regards,

Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company


http://www.linkedin.com/in/asheshvashi


On Tue, Mar 13, 2018 at 6:18 AM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Dave Page-7
In reply to this post by Murtuza Zabuawala


On Tue, Mar 13, 2018 at 12:12 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Ashesh,

I haven't implemented that intentionally because Khushboo is working on the same for SSL and our code will conflict, So once Khushboo's patch gets committed, I'll make changes for Service file as well.

Ashesh is right - this should have been finished (and I should have thought about this issue).

Please fix ASAP.

Thanks.
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Victoria Henry
In reply to this post by Dave Page-7
Hi Dave,

We've made updated our previous patch to fix the error messages.  Attached are our updated patches.

On Mon, Mar 12, 2018 at 8:48 PM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


refactor-javascript.diff (27K) Download Attachment
revert-upgrade-of-jasmine.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#3140] Add service parameter

Dave Page-7
Thanks, patches applied!

On Tue, Mar 13, 2018 at 9:53 AM, Victoria Henry <[hidden email]> wrote:
Hi Dave,

We've made updated our previous patch to fix the error messages.  Attached are our updated patches.

On Mon, Mar 12, 2018 at 8:48 PM, Dave Page <[hidden email]> wrote:
Hi

On Mon, Mar 12, 2018 at 5:18 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hi Dave and Murtuza,

Regarding this patch we refactored the Javascript code so that is lives in a different file and added some tests.

Also we found an issue with karma-jasmine that does not allow us to use jasmine 3.1 yet. You can find attached a patch that reverts that commit.

Sounds good, but neither patch will apply (in fact, the Jasmine one looks entirely backwards). One of the error messages was changed in Murtuza's patch, and wasn't reflected in your update for example.

Can you rebase please?

Thanks.
 

Thanks
Victoria && Joao

On Mon, Mar 12, 2018 at 4:46 PM Dave Page <[hidden email]> wrote:
Thanks, patch applied!

On Mon, Mar 12, 2018 at 3:31 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

PFA updated patch.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Mar 9, 2018 at 9:29 PM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

I'll change the name and send you updated patch.


On Fri, Mar 9, 2018 at 9:25 PM, Dave Page <[hidden email]> wrote:
HI

On Fri, Mar 9, 2018 at 11:47 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA patch to add service parameter in server dialog.
- Docs updated
- Test case added for Service ID parameter

Please note,
I have extracted Connection class and Server manager class from our own custom Psycopg2 driver module.

Patch also covers RM#3120

 This patch seems a little confused. The "Service" and "Service ID" fields from pgAdmin 3 are very different things. The Redmine ticket seems to be asking for the Service field (the pg_service.conf service name), *not* Service ID (the operating system's service ID, used to start/stop the database server service).

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company




--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Previous Thread Next Thread