[pgadmin4][Patch]: Display Functions node for GreenPlum database

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao

display_functions_node_on_greenplum.diff (39K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Murtuza Zabuawala
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao

Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao


Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Murtuza Zabuawala
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao



Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira
Thanks for the help Murtuza

Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum

Thanks
Joao

On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <[hidden email]> wrote:
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao





display_functions_node_on_greenplum.diff (39K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira

@Dave I sent the new patch with correction in the previous email. Can you review it and let us know if it is ok?


On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Thanks for the help Murtuza

Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum

Thanks
Joao

On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <[hidden email]> wrote:
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao





Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira
Hello Hackers,
I am updating this patch as we found out that the SQL tab was not showing the functions properly, and we corrected that in the new update patch in this email

Thanks
Joao

On Wed, Jan 17, 2018 at 12:25 PM, Joao De Almeida Pereira <[hidden email]> wrote:

@Dave I sent the new patch with correction in the previous email. Can you review it and let us know if it is ok?


On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Thanks for the help Murtuza

Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum

Thanks
Joao

On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <[hidden email]> wrote:
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao







display-functions-on-greenplum-complete.diff (40K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Joao De Almeida Pereira
Any comments on this patch? Or is it ready to merge?

On Fri, Jan 19, 2018 at 7:56 AM Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
I am updating this patch as we found out that the SQL tab was not showing the functions properly, and we corrected that in the new update patch in this email

Thanks
Joao

On Wed, Jan 17, 2018 at 12:25 PM, Joao De Almeida Pereira <[hidden email]> wrote:

@Dave I sent the new patch with correction in the previous email. Can you review it and let us know if it is ok?


On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Thanks for the help Murtuza

Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum

Thanks
Joao

On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <[hidden email]> wrote:
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Screen Shot 2018-01-11 at 10.59.28 AM.png

Can anyone explain me how these types get populated?



Thanks
Joao






Reply | Threaded
Open this post in threaded view
|

Re: [pgadmin4][Patch]: Display Functions node for GreenPlum database

Dave Page-7
In reply to this post by Joao De Almeida Pereira
Thanks, patch applied.

On Fri, Jan 19, 2018 at 12:56 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
I am updating this patch as we found out that the SQL tab was not showing the functions properly, and we corrected that in the new update patch in this email

Thanks
Joao

On Wed, Jan 17, 2018 at 12:25 PM, Joao De Almeida Pereira <[hidden email]> wrote:

@Dave I sent the new patch with correction in the previous email. Can you review it and let us know if it is ok?


On Fri, Jan 12, 2018 at 12:48 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Thanks for the help Murtuza

Attached you can find the revisited patch that now displayed all the information about functions in GreenPlum

Thanks
Joao

On Fri, Jan 12, 2018 at 9:51 AM, Murtuza Zabuawala <[hidden email]> wrote:
​Hi,

We ​create collection of existing parameters using function 'def _format_arguments_from_db(...)' in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/functions/__init__.py' @ line 454, and on client side we have backbone collection mapped with same id on line 304 (function.js)



--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Fri, Jan 12, 2018 at 8:10 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello,
I changed that function to make the retrieval quicker because the return type of all the types in the database for GreenPlum can be quite big.

Nevertheless the "Data Types" in the front end do not get filled up with the values.

Where is the Javascript code that does the mapping between the call of get_types and that table in the screenshot?

Thanks
Joao


On Fri, Jan 12, 2018 at 12:37 AM, Murtuza Zabuawala <[hidden email]> wrote:
Hi Joao,

We have written common function 'def get_types(...)' in a class called 'DataTypeReader' to fetch datatypes in a file '../pgadmin4/web/pgadmin/browser/server_groups/servers/databases/schemas/utils.py' and we have inherited from DataTypeReader in Function module's 'FunctionView' class to use it check line no. 120

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


On Thu, Jan 11, 2018 at 9:31 PM, Joao De Almeida Pereira <[hidden email]> wrote:
Hello Hackers,
We had some requests from GreenPlum users to display the functions node again.
This patch reintroduces functions as a node underneath the Schemas.


Unfortunately this patch is not final because I could not find the place where the Data Type is populated from. (See next image)Inline image 1

Can anyone explain me how these types get populated?



Thanks
Joao









--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Previous Thread Next Thread