pgsql: Fix postgres_fdw to cope with duplicate GROUP BY entries.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fix postgres_fdw to cope with duplicate GROUP BY entries.

Tom Lane-2
Fix postgres_fdw to cope with duplicate GROUP BY entries.

Commit 7012b132d, which added the ability to push down aggregates and
grouping to the remote server, wasn't careful to ensure that the remote
server would have the same idea we do about which columns are the grouping
columns, in cases where there are textually identical GROUP BY expressions.
Such cases typically led to "targetlist item has multiple sortgroupref
labels" errors.

To fix this reliably, switch over to using "GROUP BY column-number" syntax
rather than "GROUP BY expression" in transmitted queries, and adjust
foreign_grouping_ok() to be more careful about duplicating the sortgroupref
labeling of the local pathtarget.

Per bug #14890 from Sean Johnston.  Back-patch to v10 where the buggy code
was introduced.

Jeevan Chalke, reviewed by Ashutosh Bapat

Discussion: https://postgr.es/m/20171107134948.1508.94783@...

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/67854bc59a8b283f02f2a8f0c0095df639bedf06

Modified Files
--------------
contrib/postgres_fdw/deparse.c                 |  17 ++-
contrib/postgres_fdw/expected/postgres_fdw.out | 163 ++++++++++++++-----------
contrib/postgres_fdw/postgres_fdw.c            |  83 ++++++-------
contrib/postgres_fdw/sql/postgres_fdw.sql      |   6 +
4 files changed, 150 insertions(+), 119 deletions(-)

Previous Thread Next Thread