Alter table documentation page (again)

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Alter table documentation page (again)

Lætitia Avrot
Hi,

I was trying to answer a former colleague question about postgres' default behaviour when deleting or updating when she pointed out that Postgres alter table documentation page used twice the 'action' keywords for two different things.

And indeed she is right : 
- it's used to described any action actionable with ALTER TABLE statement
- and also to reference action taken on update or delete

Here are my thoughts about that conflict :
- We should keep the action keyword for on update or on delete action as it's what's done on the CREATE TABLE documentation page.
- Option 1: We could either categorized the "actions" we can do with ALTER TABLE (as column_action, trigger_action, constraint_action, rule_action, other_action), but I'm not a big fan of "other_action" and I can't think of another name 
- Option 2: Or we could just rename the first action as "alter-table_action"

Any thought ? Which option do you prefer ? I can write the patch, but I'd like to know what you think about that.

Anyway, thanks to Brigitte Blanc-Lafay tohave pointed this out! :-)

Cheers,

Lætitia
--
Think! Do you really need to print this email ?
There is no Planet B.
Reply | Threaded
Open this post in threaded view
|

Re: Alter table documentation page (again)

Alvaro Herrera-9
On 2018-Dec-06, Lætitia Avrot wrote:

> Any thought ? Which option do you prefer ? I can write the patch, but I'd
> like to know what you think about that.

I'd rename the action in ON DELETE/UPDATE to referential_action, both in
alter_table and in create_table (the latter just for consistency).

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply | Threaded
Open this post in threaded view
|

Re: Alter table documentation page (again)

Lætitia Avrot

I'd rename the action in ON DELETE/UPDATE to referential_action, both in
alter_table and in create_table (the latter just for consistency).

I love that "option 3" !  So clever!

Reply | Threaded
Open this post in threaded view
|

Re: Alter table documentation page (again)

Alvaro Herrera-9
On 2018-Dec-06, Lætitia Avrot wrote:

> > I'd rename the action in ON DELETE/UPDATE to referential_action, both in
> > alter_table and in create_table (the latter just for consistency).
>
> I love that "option 3" !  So clever!

Thanks :-)  I checked the SQL standard after sending that email, and
indeed it calls those elements <referential action>.  Go figure.

--
Álvaro Herrera                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Reply | Threaded
Open this post in threaded view
|

Re: Alter table documentation page (again)

Lætitia Avrot
Hi all,

Here's the patch.
The patch should apply to MASTER. I built and tested it successfully on my laptop.

I'll add it to January's commitfest.

Cheers,

Lætitia


referential_action_alter_or_create_table_v1.patch (8K) Download Attachment