BUG #15629: Typo in Documentation

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

BUG #15629: Typo in Documentation

apt.postgresql.org Repository Update
The following bug has been logged on the website:

Bug reference:      15629
Logged by:          Shouyu Luo
Email address:      [hidden email]
PostgreSQL version: 11.0
Operating system:   Ubuntu
Description:        

https://www.postgresql.org/docs/current/ddl-partitioning.html

5.10.5. Partitioning and Constraint Exclusion
Constraint exclusion is only applied during query planning; unlike partition
pruning, it cannot be applied during query execution.

Is it supposed to be "unlike partition pruning, it can be applied during
query execution"?

Reply | Threaded
Open this post in threaded view
|

Re: BUG #15629: Typo in Documentation

David Rowley-3
On Mon, 11 Feb 2019 at 20:49, PG Bug reporting form
<[hidden email]> wrote:
> https://www.postgresql.org/docs/current/ddl-partitioning.html
>
> 5.10.5. Partitioning and Constraint Exclusion
> Constraint exclusion is only applied during query planning; unlike partition
> pruning, it cannot be applied during query execution.
>
> Is it supposed to be "unlike partition pruning, it can be applied during
> query execution"?

That's a bit confusing. "it" looks like must have been intended to
reference constraint exclusion, but since partition pruning was
mentioned afterwards, then it makes more sense to apply it to that.

Maybe it would be more clear to write:

Constraint exclusion is only applied during query planning; unlike
partition pruning which can also be applied during query execution.

Small patch doing it that way is attached.

--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

constraint_exclusion_doc_fix.patch (734 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: BUG #15629: Typo in Documentation

Amit Langote
On Mon, Feb 11, 2019 at 5:25 PM David Rowley
<[hidden email]> wrote:

> On Mon, 11 Feb 2019 at 20:49, PG Bug reporting form
> <[hidden email]> wrote:
> > https://www.postgresql.org/docs/current/ddl-partitioning.html
> >
> > 5.10.5. Partitioning and Constraint Exclusion
> > Constraint exclusion is only applied during query planning; unlike partition
> > pruning, it cannot be applied during query execution.
> >
> > Is it supposed to be "unlike partition pruning, it can be applied during
> > query execution"?
>
> That's a bit confusing. "it" looks like must have been intended to
> reference constraint exclusion, but since partition pruning was
> mentioned afterwards, then it makes more sense to apply it to that.
>
> Maybe it would be more clear to write:
>
> Constraint exclusion is only applied during query planning; unlike
> partition pruning which can also be applied during query execution.
>
> Small patch doing it that way is attached.

+1

Maybe, the semicolon should be replaced by a comma?

Thanks,
Amit

Reply | Threaded
Open this post in threaded view
|

Re: Re: BUG #15629: Typo in Documentation

Chapman Flack
On 02/11/19 08:18, Amit Langote wrote:
> Maybe, the semicolon should be replaced by a comma?

I agree, and here is a version of the patch with that change.

Regards,
-Chap

constraint_exclusion_doc_fix-1.patch (638 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Re: BUG #15629: Typo in Documentation

David Rowley-3
On Tue, 12 Feb 2019 at 14:21, Chapman Flack <[hidden email]> wrote:
>
> On 02/11/19 08:18, Amit Langote wrote:
> > Maybe, the semicolon should be replaced by a comma?
>
> I agree, and here is a version of the patch with that change.

Agreed about the comma.  Thanks for updating the patch.


--
 David Rowley                   http://www.2ndQuadrant.com/
 PostgreSQL Development, 24x7 Support, Training & Services

Reply | Threaded
Open this post in threaded view
|

Re: Re: BUG #15629: Typo in Documentation

Michael Paquier-2
On Tue, Feb 12, 2019 at 03:09:30PM +1300, David Rowley wrote:
> Agreed about the comma.  Thanks for updating the patch.

Cool for me, so pushed down to v11.
--
Michael

signature.asc (849 bytes) Download Attachment