Re: BUG #16268: SPI_getvalue requires IsTransactionState but TextDatumGetCString of SPI_getbinval - not!
On Thu, Feb 20, 2020 at 05:06:24AM +0000, PG Bug reporting form wrote:
> const char *data = SPI_getvalue(SPI_tuptable->vals[row],
> SPI_tuptable->tupdesc, SPI_fnumber(SPI_tuptable->tupdesc, "data"));
> raise TRAP: FailedAssertion("!(IsTransactionState())", File: "catcache.c",
> Line: 1213)
Catalog cache lookups have to happen in the context of a transaction,
this is what this assertion failure means, so your code is doing
something incorrect. We have such examples of short-term transactions
opened in the PostgreSQL code for some cache lookups.
IdentifySystem() in walsender.c looking for the database name is one
such example (see StartTransactionCommand and CommitTransactionCommand).