Broken links on contributor profiles

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Broken links on contributor profiles

Daniel Gustafsson
On contributor profiles we make the assumption that if company is set then so
is companyurl, which doesn't hold generating a link with href="".  The attached
(untested patch) adds a check on companyurl, and renders company as plain text
unless set.

cheers ./daniel


contributor_link.diff (605 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Broken links on contributor profiles

Jonathan S. Katz-3
On 11/5/20 3:06 PM, Daniel Gustafsson wrote:
> On contributor profiles we make the assumption that if company is set then so
> is companyurl, which doesn't hold generating a link with href="".  The attached
> (untested patch) adds a check on companyurl, and renders company as plain text
> unless set.

Thanks for catching this. Unfortunately the patch as is does not
actually work due to one of the "{% endif %}" blocks coming too early.

I went ahead, fixed it, and pushed up the patch.

Thanks!

Jonathan