Bug in configure-detection of wxaui

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Bug in configure-detection of wxaui

Florian Pflug-2
Hi

Building currently fails at least on OSX, but I guess it fails on *nix
too. WXAUI_HOME gets set to the _root_ auf the wxaui sources, but is
later (when doing CPPFLAGS = -I$WXAUI_HOME) assumed to contain the
include directory (<wxaui-root>/include).

The following (trivial) patch helps:
Index: acinclude.m4
===================================================================
--- acinclude.m4        (revision 5245)
+++ acinclude.m4        (working copy)
@@ -516,7 +516,7 @@
  #######################
  AC_DEFUN([SETUP_WXAUI],
  [
-       CPPFLAGS="$CPPFLAGS -I${WXAUI_HOME}"
+       CPPFLAGS="$CPPFLAGS -I${WXAUI_HOME}/include"
  ])

  ###########

greetings, Florian Pflug

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq
Reply | Threaded
Open this post in threaded view
|

Re: Bug in configure-detection of wxaui

Dave Page
 

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]] On Behalf Of
> Florian G. Pflug
> Sent: 05 July 2006 09:17
> To: pgadmin-hackers
> Subject: [pgadmin-hackers] Bug in configure-detection of wxaui
>
> Hi
>
> Building currently fails at least on OSX, but I guess it
> fails on *nix
> too. WXAUI_HOME gets set to the _root_ auf the wxaui sources, but is
> later (when doing CPPFLAGS = -I$WXAUI_HOME) assumed to contain the
> include directory (<wxaui-root>/include).

That's weird - it certainly did work on Linux when I tested it. Oh well,
must have been something left in my environment from earlier hacking.

Thanks, patch applied.

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster
Reply | Threaded
Open this post in threaded view
|

Re: Bug in configure-detection of wxaui

Florian Pflug-2
In reply to this post by Florian Pflug-2
Florian G. Pflug wrote:
> Hi
>
> Building currently fails at least on OSX, but I guess it fails on *nix
> too. WXAUI_HOME gets set to the _root_ auf the wxaui sources, but is
> later (when doing CPPFLAGS = -I$WXAUI_HOME) assumed to contain the
> include directory (<wxaui-root>/include).

And here is why the error above probably didn't bit you, even on
linux, dave ;-)

src/Makefile.am adds "-I/usr/local/src/wxaui/include" to CPPFLAGS,
independent of where acinclude.m4 thinks wxaui can be found.

Another (trivial) patch is attached.

greetings, Florian Pflug


Index: Makefile.am
===================================================================
--- Makefile.am (revision 5245)
+++ Makefile.am (working copy)
@@ -39,9 +39,9 @@
 if !APPBUNDLE
 
 nobase_dist_pkgdata_DATA = $(TMP_ui)
-AM_CXXFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
-AM_CPPFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
-AM_CFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
+AM_CXXFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
+AM_CPPFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
+AM_CFLAGS = -DDATA_DIR=\"$(pkgdatadir)/\" -Wall -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
 
 # Automake trys to execute install-exec-hook if it appears anywhere in the file, so we need a dummy
 # for non-APPBUNDLE cases.
@@ -50,9 +50,9 @@
 else
 
 nobase_dist_data_DATA = $(TMP_ui)
-AM_CXXFLAGS = -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
-AM_CPPFLAGS = -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
-AM_CFLAGS = -Wall -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include -I/usr/local/src/wxaui-0.9.2/include
+AM_CXXFLAGS = -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
+AM_CPPFLAGS = -Wall -Wno-non-virtual-dtor -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
+AM_CFLAGS = -Wall -I$(top_srcdir)/src/include -I$(top_srcdir)/src/agent/include -I$(top_srcdir)/src/slony/include
 
 install-exec-hook:
  cd $(bindir) ;\


---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq
Reply | Threaded
Open this post in threaded view
|

Re: Bug in configure-detection of wxaui

Dave Page
 

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]] On Behalf Of
> Florian G. Pflug
> Sent: 05 July 2006 09:37
> To: Florian G. Pflug
> Cc: pgadmin-hackers
> Subject: Re: [pgadmin-hackers] Bug in configure-detection of wxaui
>
> Florian G. Pflug wrote:
> > Hi
> >
> > Building currently fails at least on OSX, but I guess it
> fails on *nix
> > too. WXAUI_HOME gets set to the _root_ auf the wxaui sources, but is
> > later (when doing CPPFLAGS = -I$WXAUI_HOME) assumed to contain the
> > include directory (<wxaui-root>/include).
>
> And here is why the error above probably didn't bit you, even on
> linux, dave ;-)
>
> src/Makefile.am adds "-I/usr/local/src/wxaui/include" to CPPFLAGS,
> independent of where acinclude.m4 thinks wxaui can be found.

Yup, that was added when I was first testing before I wrote the autoconf
code. Well spotted!

Patch applied, thanks.

Regards, Dave.

---------------------------(end of broadcast)---------------------------
TIP 3: Have you checked our extensive FAQ?

               http://www.postgresql.org/docs/faq