Fix typo in test code comments

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Fix typo in test code comments

Kato, Sho
Hi,

I think ts_vector is a typo for tsvector.

regards,
Sho Kato

fix-typo-for-tsvector.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo in test code comments

Kyotaro HORIGUCHI-2
Hello.

At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <[hidden email]> wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>
> Hi,
>
> I think ts_vector is a typo for tsvector.

> --- ts_vector corner cases
> +-- tsvector corner cases
>  select to_tsvector('""'::json);

Yeah, surely it is typo, but not for tsvector but
to_tsvector. See the block just below.

> -- json_to_tsvector corner cases
> select json_to_tsvector('""'::json, '"all"');


regards.

--
Kyotaro Horiguchi
NTT Open Source Software Center


Reply | Threaded
Open this post in threaded view
|

RE: Fix typo in test code comments

Kato, Sho
At Friday, March 15, 2019 2:24 PM, Kyotaro HORIGUCHI wrote
> Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
> block just below.
>
> > -- json_to_tsvector corner cases
> > select json_to_tsvector('""'::json, '"all"');

Oops, thank you for your advice.
I fixed it.

Regards,
Sho Kato

> -----Original Message-----
> From: Kyotaro HORIGUCHI [mailto:[hidden email]]
> Sent: Friday, March 15, 2019 2:24 PM
> To: Kato, Sho/加藤 翔 <[hidden email]>
> Cc: [hidden email]
> Subject: Re: Fix typo in test code comments
>
> Hello.
>
> At Fri, 15 Mar 2019 04:37:03 +0000, "Kato, Sho" <[hidden email]>
> wrote in <25C1C6B2E7BE044889E4FE8643A58BA963E1D03D@G01JPEXMBKW03>
> > Hi,
> >
> > I think ts_vector is a typo for tsvector.
>
> > --- ts_vector corner cases
> > +-- tsvector corner cases
> >  select to_tsvector('""'::json);
>
> Yeah, surely it is typo, but not for tsvector but to_tsvector. See the
> block just below.
>
> > -- json_to_tsvector corner cases
> > select json_to_tsvector('""'::json, '"all"');
>
>
> regards.
>
> --
> Kyotaro Horiguchi
> NTT Open Source Software Center
>
>


fix-typo-for-tsvector-v2.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo in test code comments

Michael Paquier-2
In reply to this post by Kyotaro HORIGUCHI-2
On Fri, Mar 15, 2019 at 02:24:29PM +0900, Kyotaro HORIGUCHI wrote:
> Yeah, surely it is typo, but not for tsvector but
> to_tsvector. See the block just below.

Yes, I agree with Horiguchi-san here that this refers to the function
call, and not the data type.  Everybody agrees?
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Fix typo in test code comments

Michael Paquier-2
In reply to this post by Kato, Sho
On Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:
> Oops, thank you for your advice.
> I fixed it.

Committed.
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

RE: Fix typo in test code comments

Kato, Sho
> Committed.

Thanks!

Regards,
sho kato

> -----Original Message-----
> From: Michael Paquier [mailto:[hidden email]]
> Sent: Friday, March 15, 2019 4:24 PM
> To: Kato, Sho/加藤 翔 <[hidden email]>
> Cc: 'Kyotaro HORIGUCHI' <[hidden email]>;
> [hidden email]
> Subject: Re: Fix typo in test code comments
>
> On Fri, Mar 15, 2019 at 05:49:47AM +0000, Kato, Sho wrote:
> > Oops, thank you for your advice.
> > I fixed it.
>
> Committed.
> --
> Michael