Minor fix in reloptions.c comments

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Minor fix in reloptions.c comments

Jamison, Kirk
Hi,

I found some minor grammar mistake while reading reloptions.c code comments.
Attached is the fix.
I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
  - * values has no affect until the ...
  + * values has no effect until the ...

Regards,
Kirk Jamison

reloptions-comment-fix.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Minor fix in reloptions.c comments

Michael Paquier-2
On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> I found some minor grammar mistake while reading reloptions.c code comments.
> Attached is the fix.
> I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
>   - * values has no affect until the ...
>   + * values has no effect until the ...

A lot of those parameter updates affect processing and still they have
many side effects, as per those paragraphs.

Fixed, thanks!
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Minor fix in reloptions.c comments

Robert Haas
On Fri, Apr 12, 2019 at 12:01 AM Michael Paquier <[hidden email]> wrote:
> On Fri, Apr 12, 2019 at 02:41:37AM +0000, Jamison, Kirk wrote:
> > I found some minor grammar mistake while reading reloptions.c code comments.
> > Attached is the fix.
> > I just changed "affect" to "effect", for both n_distinct and vacuum_truncate.
> >   - * values has no affect until the ...
> >   + * values has no effect until the ...
>
> A lot of those parameter updates affect processing and still they have
> many side effects, as per those paragraphs.

Well, "has no affect" is clearly wrong here, and Kirk's fix is clearly
right.  I don't know what your point here is.

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company