Minor patch to fix reggression of select2 option

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Minor patch to fix reggression of select2 option

Neel Patel
Hi Team,

Please find attached patch to fix the issue where we should properly assigned 'dropdownParent'  select2 options.

This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717

Do review it and let us know for comments.

Thanks,
Neel Patel

select2_options.patch (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Minor patch to fix reggression of select2 option

Dave Page-7
Hi

What's the RM for this?

On Tue, Apr 30, 2019 at 8:00 AM Neel Patel <[hidden email]> wrote:
Hi Team,

Please find attached patch to fix the issue where we should properly assigned 'dropdownParent'  select2 options.

This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717

Do review it and let us know for comments.

Thanks,
Neel Patel


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: Minor patch to fix reggression of select2 option

Neel Patel
Hi Dave,

RM is 4218

Thanks,
Neel Patel

On Tue, Apr 30, 2019 at 1:25 PM Dave Page <[hidden email]> wrote:
Hi

What's the RM for this?

On Tue, Apr 30, 2019 at 8:00 AM Neel Patel <[hidden email]> wrote:
Hi Team,

Please find attached patch to fix the issue where we should properly assigned 'dropdownParent'  select2 options.

This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717

Do review it and let us know for comments.

Thanks,
Neel Patel


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: Minor patch to fix reggression of select2 option

Dave Page-7
Thanks, applied.

Note to Akshay: When you tag 4.6, please make sure it is on the correct commit, and if we need to rewrap, you may need to move this issue to the 4.6 release notes.

Thanks!

On Tue, Apr 30, 2019 at 9:22 AM Neel Patel <[hidden email]> wrote:
Hi Dave,

RM is 4218

Thanks,
Neel Patel

On Tue, Apr 30, 2019 at 1:25 PM Dave Page <[hidden email]> wrote:
Hi

What's the RM for this?

On Tue, Apr 30, 2019 at 8:00 AM Neel Patel <[hidden email]> wrote:
Hi Team,

Please find attached patch to fix the issue where we should properly assigned 'dropdownParent'  select2 options.

This was regression of commit 6016a5ee989a8f3f56c4a03994eb57989c3c0717

Do review it and let us know for comments.

Thanks,
Neel Patel


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company