[PATCH] Add some useful asserts into View Options macroses

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[PATCH] Add some useful asserts into View Options macroses

Nikolay Shaplov
This thread is a follow up to the thread https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've been trying to remove StdRdOptions
structure and replace it with unique structure for each relation kind.

I've decided to split that patch into smaller parts.

This part adds some asserts to ViewOptions macroses.
Since an option pointer there is converted into (ViewOptions *) it would be
really good to make sure that this macros is called in proper context, and we
do the convertation properly. At least when running tests with asserts turned
on.

--
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)

some-asserts-for-view-options-macroses_v1.diff (2K) Download Attachment
signature.asc (499 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add some useful asserts into View Options macroses

Robert Haas
On Sat, Oct 5, 2019 at 5:23 PM Nikolay Shaplov <[hidden email]> wrote:

> This thread is a follow up to the thread https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've been trying to remove StdRdOptions
> structure and replace it with unique structure for each relation kind.
>
> I've decided to split that patch into smaller parts.
>
> This part adds some asserts to ViewOptions macroses.
> Since an option pointer there is converted into (ViewOptions *) it would be
> really good to make sure that this macros is called in proper context, and we
> do the convertation properly. At least when running tests with asserts turned
> on.

Seems like a good idea.  Should we try to do something similar for the
macros in that header file that cast to StdRdOptions?

--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add some useful asserts into View Options macroses

Nikolay Shaplov
В письме от понедельник, 7 октября 2019 г. 12:59:27 MSK пользователь Robert
Haas написал:

> > This thread is a follow up to the thread
> > https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've
> > been trying to remove StdRdOptions structure and replace it with unique
> > structure for each relation kind.
> >
> > I've decided to split that patch into smaller parts.
> >
> > This part adds some asserts to ViewOptions macroses.
> > Since an option pointer there is converted into (ViewOptions *) it would
> > be
> > really good to make sure that this macros is called in proper context, and
> > we do the convertation properly. At least when running tests with asserts
> > turned on.
> Seems like a good idea.  Should we try to do something similar for the
> macros in that header file that cast to StdRdOptions?

That would not be as easy as for ViewOptions. For example as for the current
master code, fillfactor from StdRdOptions is used in Toast, Heap, Hash index,
nbtree index, and spgist index. This will make RelationGetFillFactor macros a
bit complicated for example.

Now I have patches that limits usage of StdRdOptions to Heap and Toast.

When StdRdOptions is not that widely used, we whould be able to add asserts
for it, it will not make the code too complex.

So I would suggest to do ViewOptions asserts now, and keep dealing with
StdRdOptions for later. When we are finished with my current patches, I will
take care about it.

--
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add some useful asserts into View Options macroses

Peter Eisentraut-6
On 2019-10-08 12:44, Nikolay Shaplov wrote:

> В письме от понедельник, 7 октября 2019 г. 12:59:27 MSK пользователь Robert
> Haas написал:
>
>>> This thread is a follow up to the thread
>>> https://www.postgresql.org/message-id/2620882.s52SJui4ql@x200m where I've
>>> been trying to remove StdRdOptions structure and replace it with unique
>>> structure for each relation kind.
>>>
>>> I've decided to split that patch into smaller parts.
>>>
>>> This part adds some asserts to ViewOptions macroses.
>>> Since an option pointer there is converted into (ViewOptions *) it would
>>> be
>>> really good to make sure that this macros is called in proper context, and
>>> we do the convertation properly. At least when running tests with asserts
>>> turned on.

Committed.

I simplified the parentheses by one level from your patch.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services


Reply | Threaded
Open this post in threaded view
|

Re: [PATCH] Add some useful asserts into View Options macroses

Nikolay Shaplov
В письме от пятница, 1 ноября 2019 г. 13:29:58 MSK пользователь Peter
Eisentraut написал:
 
> Committed.
>
> I simplified the parentheses by one level from your patch.
Thank you!

--
Software Developer: https://www.upwork.com/freelancers/~014a87e140ff02c0da
Body-oriented Therapist: https://vk.com/nataraj_rebalancing  (Russian)