POLL: Adding transaction status to default psql prompt

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
25 messages Options
12
Reply | Threaded
Open this post in threaded view
|

POLL: Adding transaction status to default psql prompt

Vik Fearing-6
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Nikolay Samokhvalov
+1 of course

On Wed, Feb 5, 2020 at 6:55 PM Vik Fearing <[hidden email]> wrote:
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

RE: POLL: Adding transaction status to default psql prompt

Ahmed, Nawaz (Fuji Xerox Australia)
In reply to this post by Vik Fearing-6
+1

-----Original Message-----
From: Vik Fearing <[hidden email]>
Sent: Thursday, 6 February 2020 1:55 PM
To: [hidden email]
Subject: POLL: Adding transaction status to default psql prompt

Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was requested.

Please answer +1 if you want or don't mind seeing transaction status by default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing



IMPORTANT NOTE: Fuji Xerox email transmission, including any attachments, is private and confidential and may contain legally privileged information. It is for the addressee's attention only. If you are not the intended recipient and have received this transmission, you must not use, edit, print, copy or disclose its contents to any person or disseminate the information contained herein or hereto attached, and you must notify sender immediately by return email and delete this transmission from your system. Any confidentiality, privilege or copyright is not waived or lost because this e-mail has been sent to you in error. We have used reasonable efforts to protect this transmission from computer viruses and other malicious software, but no warranty is made and the sender takes no responsibility for any loss or damage incurred from using this email or the information contained in this email.
Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Matt Zagrabelny
+1

On Wed, Feb 5, 2020 at 9:15 PM Ahmed, Nawaz (Fuji Xerox Australia)
<[hidden email]> wrote:

>
> +1
>
> -----Original Message-----
> From: Vik Fearing <[hidden email]>
> Sent: Thursday, 6 February 2020 1:55 PM
> To: [hidden email]
> Subject: POLL: Adding transaction status to default psql prompt
>
> Hello,
>
> I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.
>
> The effect of this is:
>
> - nothing at all when not in a transaction,
> - adding a '*' when in a transaction or a '!' when in an aborted
>   transaction.
>
> Before making a change to a long-time default, a poll in this group was requested.
>
> Please answer +1 if you want or don't mind seeing transaction status by default in psql or -1 if you would prefer to keep the current default.
>
> Thanks!
>
> +1 from me.
> --
> Vik Fearing
>
>
>
> IMPORTANT NOTE: Fuji Xerox email transmission, including any attachments, is private and confidential and may contain legally privileged information. It is for the addressee's attention only. If you are not the intended recipient and have received this transmission, you must not use, edit, print, copy or disclose its contents to any person or disseminate the information contained herein or hereto attached, and you must notify sender immediately by return email and delete this transmission from your system. Any confidentiality, privilege or copyright is not waived or lost because this e-mail has been sent to you in error. We have used reasonable efforts to protect this transmission from computer viruses and other malicious software, but no warranty is made and the sender takes no responsibility for any loss or damage incurred from using this email or the information contained in this email.


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Ian Barwick-3
In reply to this post by Vik Fearing-6
On Thu, 6 Feb 2020 at 11:55, Vik Fearing <[hidden email]> wrote:
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

+1 from me.

I've been configuring this in every single .psqlrc I "own" since it was first added in 7.4,
and sorely miss it not being just available in environments I don't "own".


Regards

Ian Barwick

Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Steve Baldwin
In reply to this post by Vik Fearing-6
Hi Vik,

I'm not sure why this should be the default when it is easy to override the default via a psqrc file. If you know enough to do it, you can. Otherwise I don't think it adds any value as a default since a novice user isn't going to know what */!/? means. Maybe I'm missing something.

-1 from me.

On Thu, Feb 6, 2020 at 1:55 PM Vik Fearing <[hidden email]> wrote:
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Vik Fearing-6
On 06/02/2020 04:55, Steve Baldwin wrote:
> Hi Vik,
>
> I'm not sure why this should be the default when it is easy to override the
> default via a psqrc file. If you know enough to do it, you can.

Because it isn't always easy to modify the .psqlrc file.  This is
especially true if you frequently connect to other people's systems.

> Otherwise I
> don't think it adds any value as a default since a novice user isn't going
> to know what */!/? means. Maybe I'm missing something.

A novice user won't understand any of psql's meta commands, either.

> -1 from me.

Thank you for voting.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Hari Kiran
In reply to this post by Vik Fearing-6

On 06/02/20 8:24 am, Vik Fearing wrote:

> Hello,
>
> I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.
>
> The effect of this is:
>
> - nothing at all when not in a transaction,
> - adding a '*' when in a transaction or a '!' when in an aborted
>    transaction.
>
> Before making a change to a long-time default, a poll in this group was
> requested.
>
> Please answer +1 if you want or don't mind seeing transaction status by
> default in psql or -1 if you would prefer to keep the current default.
>
> Thanks!
>
> +1 from me.
double +1 from me


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Michael Paquier-2
In reply to this post by Vik Fearing-6
On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:

> I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.
>
> The effect of this is:
>
> - nothing at all when not in a transaction,
> - adding a '*' when in a transaction or a '!' when in an aborted
>   transaction.
>
> Before making a change to a long-time default, a poll in this group was
> requested.
Thanks Vik for starting a new thread.  For reference here is the
thread where the patch is being discussed:
https://www.postgresql.org/message-id/09502c40-cfe1-bb29-10f9-4b3fa7b2bbb2@...
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Christophe Pettus-2
In reply to this post by Vik Fearing-6


> On Feb 5, 2020, at 18:54, Vik Fearing <[hidden email]> wrote:
> Please answer +1 if you want or don't mind seeing transaction status by
> default in psql or -1 if you would prefer to keep the current default.

+1.



Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Adrian Klaver-4
In reply to this post by Vik Fearing-6
On 2/5/20 8:05 PM, Vik Fearing wrote:

> On 06/02/2020 04:55, Steve Baldwin wrote:
>> Hi Vik,
>>
>> I'm not sure why this should be the default when it is easy to override the
>> default via a psqrc file. If you know enough to do it, you can.
>
> Because it isn't always easy to modify the .psqlrc file.  This is
> especially true if you frequently connect to other people's systems.
>
>> Otherwise I
>> don't think it adds any value as a default since a novice user isn't going
>> to know what */!/? means. Maybe I'm missing something.
>
> A novice user won't understand any of psql's meta commands, either.

Except they can be found by doing \?

-1

>
>> -1 from me.
>
> Thank you for voting.
>


--
Adrian Klaver
[hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

David G Johnston
In reply to this post by Vik Fearing-6
On Wed, Feb 5, 2020 at 7:55 PM Vik Fearing <[hidden email]> wrote:
Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.
 
+1
 
Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Daevor The Devoted
In reply to this post by Vik Fearing-6
+1

(+10 billion actually, but sadly, I'm only allowed a +1)

On Thu, Feb 6, 2020 at 4:55 AM Vik Fearing <[hidden email]> wrote:
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,
- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Laurenz Albe
In reply to this post by Vik Fearing-6
On Thu, 2020-02-06 at 03:54 +0100, Vik Fearing wrote:
> I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

+1

Yours,
Laurenz Albe



Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Guillaume Lelarge-3
In reply to this post by Vik Fearing-6
Le jeu. 6 févr. 2020 à 03:55, Vik Fearing <[hidden email]> a écrit :
Hello,

I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.

The effect of this is:

- nothing at all when not in a transaction,

Too bad it doesn't add a space, so that we still have the same space used byt the prompt whatever the status of the transaction. That's probably the only thing that bugs me with %x.

- adding a '*' when in a transaction or a '!' when in an aborted
  transaction.

Before making a change to a long-time default, a poll in this group was
requested.

Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.

Thanks!

+1 from me.

+1 from me as well. Actually, thanks to you, I added it to my .psqlrc file in the meantime. But it would be very interesting when I work on a customer's server.


--
Guillaume.
Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

hubert depesz lubaczewski-2
In reply to this post by Vik Fearing-6
On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:
> Please answer +1 if you want or don't mind seeing transaction status by
> default in psql or -1 if you would prefer to keep the current default.

+1

depesz


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Daniel Westermann (DWE)
>On Thu, Feb 06, 2020 at 03:54:48AM +0100, Vik Fearing wrote:
>> Please answer +1 if you want or don't mind seeing transaction status by
>> default in psql or -1 if you would prefer to keep the current default.
>
>+1

+1

Daniel


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Ray O'Donnell
In reply to this post by Vik Fearing-6
On 06/02/2020 02:54, Vik Fearing wrote:

> Hello,
>
> I proposed a patch to add %x to PROMPT1 and PROMPT2 by default in psql.
>
> The effect of this is:
>
> - nothing at all when not in a transaction,
> - adding a '*' when in a transaction or a '!' when in an aborted
>   transaction.
>
> Before making a change to a long-time default, a poll in this group was
> requested.
>
> Please answer +1 if you want or don't mind seeing transaction status by
> default in psql or -1 if you would prefer to keep the current default.

+1


--
Raymond O'Donnell // Galway // Ireland
[hidden email]


Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Victor Yegorov
In reply to this post by Vik Fearing-6
чт, 6 февр. 2020 г. в 04:55, Vik Fearing <[hidden email]>:
Please answer +1 if you want or don't mind seeing transaction status by
default in psql or -1 if you would prefer to keep the current default.


+1
 
--
Victor Yegorov
Reply | Threaded
Open this post in threaded view
|

Re: POLL: Adding transaction status to default psql prompt

Charles Clavadetscher
In reply to this post by Vik Fearing-6
> Please answer +1 if you want or don't mind seeing transaction status by
> default in psql or -1 if you would prefer to keep the current default.

+1

--
Charles Clavadetscher
Swiss PostgreSQL Users Group
Treasurer
Spitzackerstrasse 9
CH - 8057 Zürich

http://www.swisspug.org

+---------------------------+
|     ____  ______  ___     |
|    /    )/      \/   \    |
|   (     / __    _\    )   |
|    \    (/ o)  ( o)   )   |
|     \_  (_  )   \ ) _/    |
|       \  /\_/    \)/      |
|        \/ <//|  |\\>      |
|             _|  |         |
|             \|_/          |
|                           |
|     Swiss PGDay 2020      |
|      18/19.06.2020        |
|      HSR Rapperswil       |
|                           |
+---------------------------+


12