[Patch][pgAdmin] RM4203 Rename Database by another user

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[Patch][pgAdmin] RM4203 Rename Database by another user

Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.

RM4203.patch (13K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Akshay Joshi
Hi Rahul

Following are the review comments:
  • Why you have changed the order of the toolbar button on the browser tree? It should not. 
  • sqleditor.js (check_db_name_change function)
    • var declaration should be comma-separated instead of writing var, again and again.
    • Add proper comments.
    • Remove dots from the string "Database moved/renamed.."
    • "Please note that the database you are working on has been moved or renamed to ${data.actual_db_name}. Refresh databases in browser panel or click OK to continue.." should be changed to "Current database has been moved or renamed to ${data.actual_db_name}. Click on the OK button to refresh the database name." 


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Rahul Shirsat
Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

Following are the review comments:
  • Why you have changed the order of the toolbar button on the browser tree? It should not.
               Changes were related to the wcDocker issue showing reverse order buttons, so had to change in the pgAdmin app to reflect it correctly.
  • sqleditor.js (check_db_name_change function)
    • var declaration should be comma-separated instead of writing var, again and again.
                          Done. 
    • Add proper comments.
                          This too is taken care of. 
    • Remove dots from the string "Database moved/renamed.."
                          Done. 
    • "Please note that the database you are working on has been moved or renamed to ${data.actual_db_name}. Refresh databases in browser panel or click OK to continue.." should be changed to "Current database has been moved or renamed to ${data.actual_db_name}. Click on the OK button to refresh the database name." 
                          Done. 
                           Also have done some code refactoring.


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.

RM4203_v2.patch (142K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Akshay Joshi
Thanks, the patch applied.

On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

Following are the review comments:
  • Why you have changed the order of the toolbar button on the browser tree? It should not.
               Changes were related to the wcDocker issue showing reverse order buttons, so had to change in the pgAdmin app to reflect it correctly.
  • sqleditor.js (check_db_name_change function)
    • var declaration should be comma-separated instead of writing var, again and again.
                          Done. 
    • Add proper comments.
                          This too is taken care of. 
    • Remove dots from the string "Database moved/renamed.."
                          Done. 
    • "Please note that the database you are working on has been moved or renamed to ${data.actual_db_name}. Refresh databases in browser panel or click OK to continue.." should be changed to "Current database has been moved or renamed to ${data.actual_db_name}. Click on the OK button to refresh the database name." 
                          Done. 
                           Also have done some code refactoring.


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Rahul Shirsat
Hi Akshay,

Please find the updated patch below for your reference. I have added an extra check for verifying the database rename.
Sorry for the inconvenience caused.

On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi <[hidden email]> wrote:
Thanks, the patch applied.

On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

Following are the review comments:
  • Why you have changed the order of the toolbar button on the browser tree? It should not.
               Changes were related to the wcDocker issue showing reverse order buttons, so had to change in the pgAdmin app to reflect it correctly.
  • sqleditor.js (check_db_name_change function)
    • var declaration should be comma-separated instead of writing var, again and again.
                          Done. 
    • Add proper comments.
                          This too is taken care of. 
    • Remove dots from the string "Database moved/renamed.."
                          Done. 
    • "Please note that the database you are working on has been moved or renamed to ${data.actual_db_name}. Refresh databases in browser panel or click OK to continue.." should be changed to "Current database has been moved or renamed to ${data.actual_db_name}. Click on the OK button to refresh the database name." 
                          Done. 
                           Also have done some code refactoring.


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.

RM4203_v3.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Patch][pgAdmin] RM4203 Rename Database by another user

Akshay Joshi
Thanks, the patch applied.

On Mon, Jun 7, 2021 at 5:08 PM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

Please find the updated patch below for your reference. I have added an extra check for verifying the database rename.
Sorry for the inconvenience caused.

On Tue, Jun 1, 2021 at 8:50 PM Akshay Joshi <[hidden email]> wrote:
Thanks, the patch applied.

On Sun, May 30, 2021 at 12:03 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

On Thu, May 27, 2021 at 12:19 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

Following are the review comments:
  • Why you have changed the order of the toolbar button on the browser tree? It should not.
               Changes were related to the wcDocker issue showing reverse order buttons, so had to change in the pgAdmin app to reflect it correctly.
  • sqleditor.js (check_db_name_change function)
    • var declaration should be comma-separated instead of writing var, again and again.
                          Done. 
    • Add proper comments.
                          This too is taken care of. 
    • Remove dots from the string "Database moved/renamed.."
                          Done. 
    • "Please note that the database you are working on has been moved or renamed to ${data.actual_db_name}. Refresh databases in browser panel or click OK to continue.." should be changed to "Current database has been moved or renamed to ${data.actual_db_name}. Click on the OK button to refresh the database name." 
                          Done. 
                           Also have done some code refactoring.


On Wed, May 26, 2021 at 2:07 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of renaming the database by another user.

A minor issue of navigation button alignment is also fixed in this patch.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246