Problem with autocomplete

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Problem with autocomplete

Andreas Pflug
When triggering autocomplete on spaces (e.g. empty query window), a
memory damage will be triggered. If ignored, the full keyword listbox
will popup.
Happens with VC6, not gtk.

Regards,
Andreas

---------------------------(end of broadcast)---------------------------
TIP 2: Don't 'kill -9' the postmaster
Reply | Threaded
Open this post in threaded view
|

Re: Problem with autocomplete

Magnus Hagander
> When triggering autocomplete on spaces (e.g. empty query
> window), a memory damage will be triggered. If ignored, the
> full keyword listbox will popup.
> Happens with VC6, not gtk.

Apologies for the delay in dealing with this, been way too busy.
Attached is a fix. A buffer in _complete_from_list() wasn't allocaed
with enough space for the terminating NULL. I've fixed a similar issue
in complete_create_command - I wasn't able to trigger it, but anyway.

It really should hapen on gtk as well - most likely just luck that it
didn't corrupt anything needed.

//Magnus


---------------------------(end of broadcast)---------------------------
TIP 5: don't forget to increase your free space map settings

tab.patch (972 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Problem with autocomplete

Dave Page
Thanks, patch applied.

Regards, Dave

> -----Original Message-----
> From: [hidden email]
> [mailto:[hidden email]] On Behalf Of
> Magnus Hagander
> Sent: 19 June 2006 11:39
> To: pgadmin-hackers
> Cc: Andreas Pflug
> Subject: Re: [pgadmin-hackers] Problem with autocomplete
>
> > When triggering autocomplete on spaces (e.g. empty query
> > window), a memory damage will be triggered. If ignored, the
> > full keyword listbox will popup.
> > Happens with VC6, not gtk.
>
> Apologies for the delay in dealing with this, been way too busy.
> Attached is a fix. A buffer in _complete_from_list() wasn't allocaed
> with enough space for the terminating NULL. I've fixed a similar issue
> in complete_create_command - I wasn't able to trigger it, but anyway.
>
> It really should hapen on gtk as well - most likely just luck that it
> didn't corrupt anything needed.
>
> //Magnus
>

---------------------------(end of broadcast)---------------------------
TIP 1: if posting/reading through Usenet, please send an appropriate
       subscribe-nomail command to [hidden email] so that your
       message can get through to the mailing list cleanly