Hi Team, Please find the attached designs & patch that contains complete functionality except below to do for quick search. To Do:
Please do let me know if I missed anything or suggestion of yours. Thanks ! Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679 ![]() ![]() ![]() ![]() ![]() |
Hi On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire <[hidden email]> wrote:
Looks very good. I haven't done an extensive code review/test, but two things spring to mind immediately: 1) I think the search box should be the top item on the Help menu. I do not think it should be on the far end of the menu bar, as it looks too much like it will search for data (think of search on a website). 2) Do we need another loading icon? Surely there's one in the source tree already that we can use? |
In reply to this post by Pramod Ahire
Hi Pramod Following are the review comments:
On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire <[hidden email]> wrote:
Thanks & Regards Akshay Joshi pgAdmin Hacker | Principal Software Architect EDB PostgresMobile: +91 976-788-8246 |
In reply to this post by Dave Page-7
Hi Dave, Thank you for comments ! I had described points below. Please do let me know if anything missing. From: Dave Page <[hidden email]> Hi On Thu, Jan 14, 2021 at 4:48 PM Pramod Ahire <[hidden email]> wrote:
Looks very good. I haven't done an extensive code review/test, but two things spring to mind immediately: 1) I think the search box should be the top item on the Help menu. I do not think it should be on the far end of the menu bar, as it looks too much like it will search for data (think of search on a website). - As we are showing menu items as well in search results, it can be redundant for end user & increase duplications of menu items. Please advise your thoughts on this. 2) Do we need another loading icon? Surely there's one in the source tree already that we can use? - As we are loading help articles count in background, so I have added background loading icon to show near to count of results. Our existing icon is of blue & white circle combination, which will be more useful to show foreground loading. Please do let me know your valuable inputs on this. Pramod Ahire Software Engineer C: +91-020-66449600/601 D: +91-9028697679 |
In reply to this post by Akshay Joshi
Hi Akshay, Thanks for your quick review ! Made changes as per your comments & attached patch with this email. From: Akshay Joshi <[hidden email]> Hi Pramod Following are the review comments:
On Thu, Jan 14, 2021 at 10:18 PM Pramod Ahire <[hidden email]> wrote:
-- Thanks & Regards Akshay Joshi pgAdmin Hacker | Principal Software Architect Mobile: +91 976-788-8246 |
In reply to this post by Pramod Ahire
Hi On Fri, Jan 15, 2021 at 7:23 AM Pramod Ahire <[hidden email]> wrote:
The search box could be on the Help menu, with results shown in a sub-menu under it. Another more simple option would be to move the search icon to be directly after the Help menu (which would hint that it's related to the menus), but I'm also concerned about the number of items on the top menu - we're getting to the point that 'common' window sizes would show the hamburger menu by default.
Hmm, OK.
|
Hi Dave On Fri, Jan 15, 2021 at 2:46 PM Dave Page <[hidden email]> wrote:
I personally feel we should not add the search box on the Help menu, it should be kept separate with a placeholder indicating what is it for. We can move the search icon after the Help menu.
Thanks & Regards Akshay Joshi pgAdmin Hacker | Principal Software Architect EDB PostgresMobile: +91 976-788-8246 |
On Fri, Jan 15, 2021 at 9:43 AM Akshay Joshi <[hidden email]> wrote:
What is your reasoning? It is, after all, specifically designed to help people.
|
On Fri, Jan 15, 2021 at 3:15 PM Dave Page <[hidden email]> wrote:
OK, I have seen a couple of applications where the search box is inside the Help menu, agree with your point.
Thanks & Regards Akshay Joshi pgAdmin Hacker | Principal Software Architect EDB PostgresMobile: +91 976-788-8246 |
Free forum by Nabble | Edit this page |