Re: Implement <null treatment> for window functions

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Implement <null treatment> for window functions

Krasiyan Andreev
Hi, it looks like Vik Fearing's patch does not apply anymore, because there are many conflicts with recent changes, fixed patch attached.
I am interested in reviewing and testing it for the next commitfest, if it's design and implementation is found to be acceptable.
Additionally, if it is also acceptable, I can add support for handling negative indexes for nth_value(), to be able to reverse order from first/from last for the window frame.

0001-implement-null-treatment-for-window-functions.patch (84K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Implement <null treatment> for window functions

Vik Fearing-6
On 11/12/20 11:35 PM, Krasiyan Andreev wrote:
> Hi, it looks like Vik Fearing's patch does not apply anymore, because there
> are many conflicts with recent changes, fixed patch attached.

Thanks!  I've been away from this list for a while and I have some
catching up to do.
--
Vik Fearing


Reply | Threaded
Open this post in threaded view
|

Re: Implement <null treatment> for window functions

Krasiyan Andreev
Fixed patch attached, after new introduced conflicts.
Vik, can you add it to the next commitfest, to be able to test it.
Also, all tests from Oliver Ford's old patch also passed successfully.

На пт, 13.11.2020 г. в 0:44 ч. Vik Fearing <[hidden email]> написа:
On 11/12/20 11:35 PM, Krasiyan Andreev wrote:
> Hi, it looks like Vik Fearing's patch does not apply anymore, because there
> are many conflicts with recent changes, fixed patch attached.

Thanks!  I've been away from this list for a while and I have some
catching up to do.
--
Vik Fearing

0001-implement-null-treatment-for-window-functions.patch (85K) Download Attachment