ReplicationSlotCtl: undefined reference

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

ReplicationSlotCtl: undefined reference

Pavlo Golub
Greetings.

Trying to build pg extension I've got error:
```
pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
collect2: error: ld returned 1 exit status
```

But according to https://commitfest.postgresql.org/16/1390/ it should
be marked with PGDLLIMPORT.

However checking sources there is no this spec
(https://github.com/postgres/postgres/blob/fff2a7d7bd09db38e1bafc1303c29b10a9805dc0/src/include/replication/slot.h#L172):

```
extern ReplicationSlotCtlData *ReplicationSlotCtl;
```

Am I correct or missing smth?
Craig, it supposed to be your proposal about ReplicationSlotCtl and
patch. Am I right?

--
Kind regards,
 Pavlo                          mailto:[hidden email]



Reply | Threaded
Open this post in threaded view
|

Re: ReplicationSlotCtl: undefined reference

Tom Lane-2
Pavlo Golub <[hidden email]> writes:
> Trying to build pg extension I've got error:
> ```
> pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
> collect2: error: ld returned 1 exit status
> ```

> But according to https://commitfest.postgresql.org/16/1390/ it should
> be marked with PGDLLIMPORT.

That last bit never actually got pushed, it seems.  Done now.

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: ReplicationSlotCtl: undefined reference

Pavlo Golub


On Jun 13, 2019 17:56, Tom Lane <[hidden email]> wrote:

Pavlo Golub <[hidden email]> writes:
> Trying to build pg extension I've got error:
> ```
> pglogical_monitoring.o:pglogical_monitoring.c:(.rdata$.refptr.ReplicationSlotCtl[.refptr.ReplicationSlotCtl]+0x0): undefined reference to `ReplicationSlotCtl'
> collect2: error: ld returned 1 exit status
> ```

> But according to https://commitfest.postgresql.org/16/1390/ it should
> be marked with PGDLLIMPORT.

That last bit never actually got pushed, it seems.  Done now.


Thanks Tom. Really appreciate that!


regards, tom lane