SVN Commit by dpage: r5234 - trunk/pgadmin3/src/utils

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

SVN Commit by dpage: r5234 - trunk/pgadmin3/src/utils

SVN-13
Author: dpage

Date: 2006-06-19 13:15:35 +0100 (Mon, 19 Jun 2006)

New Revision: 5234

Revision summary: http://svn.pgadmin.org/cgi-bin/viewcvs.cgi/?rev=5234&view=rev

Log:
Andreas reports:
> When triggering autocomplete on spaces (e.g. empty query
> window), a memory damage will be triggered. If ignored, the
> full keyword listbox will popup.
> Happens with VC6, not gtk.

Apologies for the delay in dealing with this, been way too busy.
Attached is a fix. A buffer in _complete_from_list() wasn't allocaed
with enough space for the terminating NULL. I've fixed a similar issue
in complete_create_command - I wasn't able to trigger it, but anyway.

It really should hapen on gtk as well - most likely just luck that it
didn't corrupt anything needed. [Magnus Hagander]



Modified:
   trunk/pgadmin3/src/utils/tabcomplete.c

---------------------------(end of broadcast)---------------------------
TIP 9: In versions below 8.0, the planner will ignore your desire to
       choose an index scan if your joining column's datatypes do not
       match