Simplify passing of configure arguments to pg_config

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Simplify passing of configure arguments to pg_config

Peter Eisentraut-6
Currently, configure puts the configure args into the makefiles and
then have the makefiles pass them to the build of pg_config.  That looks
like an unnecessary redirection, and indeed that method was
put in place when pg_config was a shell script.  We can simplify that
by having configure put the value into pg_config.h directly.  This
also makes the standard build system match how the MSVC build system
already does it.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

0001-Simplify-passing-of-configure-arguments-to-pg_config.patch (6K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Simplify passing of configure arguments to pg_config

Tom Lane-2
Peter Eisentraut <[hidden email]> writes:
> Currently, configure puts the configure args into the makefiles and
> then have the makefiles pass them to the build of pg_config.  That looks
> like an unnecessary redirection, and indeed that method was
> put in place when pg_config was a shell script.  We can simplify that
> by having configure put the value into pg_config.h directly.  This
> also makes the standard build system match how the MSVC build system
> already does it.

I dunno, is this really an improvement?  It makes the handling of
VAL_CONFIGURE different from every other one of the values passed
into pg_config, and I don't see any countervailing addition of
some other regularity.  I'm also a bit suspicious of the ad-hoc
escaping step ...

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: Simplify passing of configure arguments to pg_config

Peter Eisentraut-6
On 2019-12-03 06:03, Tom Lane wrote:

> Peter Eisentraut <[hidden email]> writes:
>> Currently, configure puts the configure args into the makefiles and
>> then have the makefiles pass them to the build of pg_config.  That looks
>> like an unnecessary redirection, and indeed that method was
>> put in place when pg_config was a shell script.  We can simplify that
>> by having configure put the value into pg_config.h directly.  This
>> also makes the standard build system match how the MSVC build system
>> already does it.
>
> I dunno, is this really an improvement?  It makes the handling of
> VAL_CONFIGURE different from every other one of the values passed
> into pg_config, and I don't see any countervailing addition of
> some other regularity.

The other values come from the makefiles, so we have to do it that way.
The configure args come from configure, so why make them go through the
makefile?  (PG_VERSION also comes in that way. ;-) )

There is also the weird difference with how the MSVC build system
handles it.  It appends VAL_CONFIGURE to pg_config.h instead of passing
it on the command line.

> I'm also a bit suspicious of the ad-hoc escaping step ...

Hmm, the current way doesn't handle embedded quotes at all, so perhaps
this wouldn't be necessary.  But it would add some robustness.

--
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services