Sonarqube fixes - test_utils.py

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Sonarqube fixes - test_utils.py

Shubham Agarwal
Hi Team,
Attached is the patch containing a fix for the SonarQube Bug in the test_utils.py file.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

sonarqube_testutils_fix.patch (934 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Sonarqube fixes - test_utils.py

Akshay Joshi
Hi Shubham

The patch is not applied because the changes that you have added in the patch is already there.

On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal <[hidden email]> wrote:
Hi Team,
Attached is the patch containing a fix for the SonarQube Bug in the test_utils.py file.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: Sonarqube fixes - test_utils.py

Shubham Agarwal
In reply to this post by Shubham Agarwal
Hi Team,
Attached is the patch to fix all the Sonar Qube related errors in test_utils.py

On Thu, Jul 30, 2020 at 4:37 PM Shubham Agarwal <[hidden email]> wrote:
Hi Murtuza,
I will check and send the fix.

On Thu, Jul 30, 2020, 4:07 PM Murtuza Zabuawala <[hidden email]> wrote:
-- pgadmin-hackers
++ PEM

Hi Shubham,

Reviewed & Committed, But sonarlint is showing 7 other issues in this file apart from this bug fix.

image.png

On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal <[hidden email]> wrote:
Hi Team,
Attached is the patch containing a fix for the SonarQube Bug in the test_utils.py file.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company

sonarqubefix_test_utils_v1.patch (18K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: Sonarqube fixes - test_utils.py

Akshay Joshi
Thanks, patch applied.

On Fri, Jul 31, 2020 at 12:07 PM Shubham Agarwal <[hidden email]> wrote:
Hi Team,
Attached is the patch to fix all the Sonar Qube related errors in test_utils.py

On Thu, Jul 30, 2020 at 4:37 PM Shubham Agarwal <[hidden email]> wrote:
Hi Murtuza,
I will check and send the fix.

On Thu, Jul 30, 2020, 4:07 PM Murtuza Zabuawala <[hidden email]> wrote:
-- pgadmin-hackers
++ PEM

Hi Shubham,

Reviewed & Committed, But sonarlint is showing 7 other issues in this file apart from this bug fix.

image.png

On Wed, Jul 29, 2020 at 6:33 PM Shubham Agarwal <[hidden email]> wrote:
Hi Team,
Attached is the patch containing a fix for the SonarQube Bug in the test_utils.py file.

--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards,
Shubham Agarwal
EnterpriseDB Corporation

The Postgres Database Company


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246