XLogRecGetFullXid()

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

XLogRecGetFullXid()

Thomas Munro-5
Hello hackers,

Here is a small patch extracted from the undo log patch set that I'd
like to discuss separately and commit soon.  I'm pretty sure that
zheap, zedstore and anyone else developing new AMs based on 64 bit
xids needs this, but there are no plans to extend WAL records to
actually carry 64 bit xids yet, and I want to discourage people from
making generic xid expanding functions that don't have any
interlocking, as I mentioned recently[1].

It's defined in xlogreader.c, because that's where such things
naturally live, but it can only work during replay for now, so I
wrapped it in a FRONTEND invisibility cloak.  That means that
front-end tools (pg_waldump.c) can't use it and will have to continue
show 32 bit xids for now.

Better ideas?

[1] https://www.postgresql.org/message-id/CA+hUKGJPuKR7i7UvmXRXhjhdW=3v1-nSO3aFn4XDLdkBJru15g@...

--
Thomas Munro
https://enterprisedb.com

0001-Add-XLogRecGetFullXid-function.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: XLogRecGetFullXid()

Thomas Munro-5
On Fri, Jul 12, 2019 at 1:25 PM Thomas Munro <[hidden email]> wrote:
> Here is a small patch extracted from the undo log patch set that I'd
> like to discuss separately and commit soon. [...]

Pushed.

--
Thomas Munro
https://enterprisedb.com