pg_bsd_indent and -Wimplicit-fallthrough

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

pg_bsd_indent and -Wimplicit-fallthrough

Michael Paquier-2
Hi,

I have just noticed that pg_bsd_indent complains since
-Wimplicit-fallthrough=3 has been added to the default set of switches
if available.

Something like the attached is fine to take care of those warnings,
but what's our current patching policy for this tool?

Thanks,
--
Michael

bsdindent-fallthru.patch (784 bytes) Download Attachment
signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Julien Rouhaud
On Fri, May 15, 2020 at 8:03 AM Michael Paquier <[hidden email]> wrote:
>
> Hi,
>
> I have just noticed that pg_bsd_indent complains since
> -Wimplicit-fallthrough=3 has been added to the default set of switches
> if available.

Oh Indeed.

> Something like the attached is fine to take care of those warnings,
> but what's our current patching policy for this tool?

The patch looks good to me.  It looks like we already have custom
patches, so +1 to applying it.


Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Daniel Gustafsson
> On 15 May 2020, at 08:28, Julien Rouhaud <[hidden email]> wrote:
> On Fri, May 15, 2020 at 8:03 AM Michael Paquier <[hidden email]> wrote:

>> Something like the attached is fine to take care of those warnings,
>> but what's our current patching policy for this tool?
>
> The patch looks good to me.  It looks like we already have custom
> patches, so +1 to applying it.

Shouldn't we try and propose it to upstream first to minimize our diff?

cheers ./daniel

Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Julien Rouhaud
On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson <[hidden email]> wrote:

>
> > On 15 May 2020, at 08:28, Julien Rouhaud <[hidden email]> wrote:
> > On Fri, May 15, 2020 at 8:03 AM Michael Paquier <[hidden email]> wrote:
>
> >> Something like the attached is fine to take care of those warnings,
> >> but what's our current patching policy for this tool?
> >
> > The patch looks good to me.  It looks like we already have custom
> > patches, so +1 to applying it.
>
> Shouldn't we try and propose it to upstream first to minimize our diff?

Good point, adding Piotr.


Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Tom Lane-2
Julien Rouhaud <[hidden email]> writes:
> On Fri, May 15, 2020 at 9:17 AM Daniel Gustafsson <[hidden email]> wrote:
>> On 15 May 2020, at 08:28, Julien Rouhaud <[hidden email]> wrote:
>>> The patch looks good to me.  It looks like we already have custom
>>> patches, so +1 to applying it.

>> Shouldn't we try and propose it to upstream first to minimize our diff?

> Good point, adding Piotr.

In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Michael Paquier-2
On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote:
> In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.

Thanks, Tom.
--
Michael

signature.asc (849 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Julien Rouhaud
On Sun, May 17, 2020 at 2:32 AM Michael Paquier <[hidden email]> wrote:
>
> On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote:
> > In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.
>
> Thanks, Tom.

+1, thanks a lot!


Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Piotr Stefaniak
On 18/05/2020 11.22, Julien Rouhaud wrote:
> On Sun, May 17, 2020 at 2:32 AM Michael Paquier <[hidden email]> wrote:
>>
>> On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote:
>>> In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.
>>
>> Thanks, Tom.
>
> +1, thanks a lot!
>

Committed upstream, thank you.


Reply | Threaded
Open this post in threaded view
|

Re: pg_bsd_indent and -Wimplicit-fallthrough

Julien Rouhaud
On Thu, May 21, 2020 at 7:39 PM Piotr Stefaniak
<[hidden email]> wrote:

>
> On 18/05/2020 11.22, Julien Rouhaud wrote:
> > On Sun, May 17, 2020 at 2:32 AM Michael Paquier <[hidden email]> wrote:
> >>
> >> On Sat, May 16, 2020 at 11:56:28AM -0400, Tom Lane wrote:
> >>> In the meantime, I went ahead and pushed this to our pg_bsd_indent repo.
> >>
> >> Thanks, Tom.
> >
> > +1, thanks a lot!
> >
>
> Committed upstream, thank you.

Thanks!