pg_dump No comment for policy

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

pg_dump No comment for policy

Marc Munro
Severity: Low
PG Server: Versions 9.5 and 10.3
pg_dump: version 10.3

I have created a policy with a comment on it.  pg_dump does not dump
the comment.

Here is my entire schema definition:
--------------------------------------------------------------------
    create table rls (
      username text not null,
      details  text not null
    );

    create policy only_owner on rls
      for all
      to session_user
      using (username = user)
      with check (details != 'xyzzy');

    comment on policy only_owner on public.rls is 'Another comment';
--------------------------------------------------------------------

pg_dump extracts the table and policy but not the comment.

I can manually extract the comment with a query:

    select p.polname, 
           quote_literal(obj_description(p.oid, 'pg_policy')) as comment
    from pg_catalog.pg_policy p;

Initially tried with postgres server 9.5.21 running from psql 10.3.
Also
tried with postgres server 10.3 running from psql 10.3.

I am not at all anxious for this to be fixed.  Just thought you should
know.

__
Marc





Reply | Threaded
Open this post in threaded view
|

Re: pg_dump No comment for policy

Tom Lane-2
Marc Munro <[hidden email]> writes:
> I have created a policy with a comment on it.  pg_dump does not dump
> the comment.

Ugh, yeah, there's no dumpComment() call in dumpPolicy().

Easy enough to fix, but now I wonder if we missed the same elsewhere.

                        regards, tom lane


Reply | Threaded
Open this post in threaded view
|

Re: pg_dump No comment for policy

Bruce Momjian
On Mon, Feb 17, 2020 at 12:59:37PM -0500, Tom Lane wrote:
> Marc Munro <[hidden email]> writes:
> > I have created a policy with a comment on it.  pg_dump does not dump
> > the comment.
>
> Ugh, yeah, there's no dumpComment() call in dumpPolicy().
>
> Easy enough to fix, but now I wonder if we missed the same elsewhere.

FYI, this was fixed on February 17 and will appear in the next minor
release:

        commit f31364676d
        Author: Tom Lane <[hidden email]>
        Date:   Mon Feb 17 18:40:02 2020 -0500
       
            Teach pg_dump to dump comments on RLS policy objects.
       
            This was unaccountably omitted in the original RLS patch.
            The SQL syntax is basically the same as for comments on triggers,
            so crib code from dumpTrigger().
       
            Per report from Marc Munro.  Back-patch to all supported branches.
       
            Discussion: https://postgr.es/m/1581889298.18009.15.camel@...

--
  Bruce Momjian  <[hidden email]>        https://momjian.us
  EnterpriseDB                             https://enterprisedb.com

+ As you are, so once was I.  As I am, so you will be. +
+                      Ancient Roman grave inscription +