[pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Rahul Shirsat
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.

RM3851_v1.patch (100K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Akshay Joshi
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Rahul Shirsat
Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.

RM3851_v2.patch (59K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Rahul Shirsat
Akshay,

Ignore the above patch, reconsider this latest patch with some optimizations.

On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.

RM3851_v3.patch (57K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Rahul Shirsat
Corrected some indentations. Find the patch below.

On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat <[hidden email]> wrote:
Akshay,

Ignore the above patch, reconsider this latest patch with some optimizations.

On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.

RM3851_v4.patch (57K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM3851] Add proper indentation to the code when generating a stored procedure

Akshay Joshi
Thanks, patch applied.

On Sun, Jun 28, 2020 at 9:46 PM Rahul Shirsat <[hidden email]> wrote:
Corrected some indentations. Find the patch below.

On Sun, Jun 28, 2020 at 9:21 PM Rahul Shirsat <[hidden email]> wrote:
Akshay,

Ignore the above patch, reconsider this latest patch with some optimizations.

On Sat, Jun 27, 2020 at 1:50 AM Rahul Shirsat <[hidden email]> wrote:
Hi Akshay,

I have made the relevant changes for existing and the new procedure, functions & triggers.

Please find the patch.

On Thu, Jun 25, 2020 at 12:21 PM Akshay Joshi <[hidden email]> wrote:
Hi Rahul

I have tested your patch and the issue is not fixed. Create one Procedure, Function, and Trigger Function using below code without applying your patch:
BEGIN
      SELECT 1;
END;

Then apply your patch and check the SQL tab. 

On Wed, Jun 24, 2020 at 12:41 AM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which fixes pg/ppas issues listed below:
  1. Stored procedure code indentation.
  2. Functions code indentation.
  3. Trigger Functions code indentation.
Please review.

--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Rahul Shirsat
Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246