[pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
31 messages Options
12
Reply | Threaded
Open this post in threaded view
|

[pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Hackers,

Attached is the patch to introduce theme options in pgAdmin.
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown. It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes. On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the svg files(monochrome) used as icons for buttons to font icons. This will allow us to change the color of icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of theme css files as CSS in .css files will not change with the change of SASS variables.
6) "Dark Beta" theme added as a new theme option.

How theme is built ?
Webpack config is changed to achieve it. On running yarn run bundle, code will read all the directories in web/pgadmin/static/scss/resources which will be considered as theme dirs, build a separate css for every theme and then create a file named pgadmin.themes.json which will have all the information required.

The patch also fixes RM4173, where there some issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4348.patch (730K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to introduce theme options in pgAdmin.
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown. It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes. On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the svg files(monochrome) used as icons for buttons to font icons. This will allow us to change the color of icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of theme css files as CSS in .css files will not change with the change of SASS variables.
6) "Dark Beta" theme added as a new theme option.

How theme is built ?
Webpack config is changed to achieve it. On running yarn run bundle, code will read all the directories in web/pgadmin/static/scss/resources which will be considered as theme dirs, build a separate css for every theme and then create a file named pgadmin.themes.json which will have all the information required.

The patch also fixes RM4173, where there some issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4348_v2.patch (750K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Akshay Joshi
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to introduce theme options in pgAdmin.
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown. It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes. On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the svg files(monochrome) used as icons for buttons to font icons. This will allow us to change the color of icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of theme css files as CSS in .css files will not change with the change of SASS variables.
6) "Dark Beta" theme added as a new theme option.

How theme is built ?
Webpack config is changed to achieve it. On running yarn run bundle, code will read all the directories in web/pgadmin/static/scss/resources which will be considered as theme dirs, build a separate css for every theme and then create a file named pgadmin.themes.json which will have all the information required.

The patch also fixes RM4173, where there some issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!


On Wed, Nov 6, 2019 at 12:32 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to introduce theme options in pgAdmin.
Changes include:
1) New theme option in preferences - Miscellaneous -> Themes. You can select the theme from the dropdown. It also has a preview of the theme just below the dropdown. Note that, a page refresh is needed to apply changes. On saving, a dialog appears to ask for refresh.
2) You can create your own theme and submit to hackers. README is updated to help you create a theme. Theme will be available only after bundle.
3) Correction of SASS variables at few places and few other CSS corrections.
4) Added iconfont-webpack-plugin, which will convert all the svg files(monochrome) used as icons for buttons to font icons. This will allow us to change the color of icon by using CSS color property.
5) All the .css files will bundle into a separate file now- pgadmin.style.css. This will help reduce the size of theme css files as CSS in .css files will not change with the change of SASS variables.
6) "Dark Beta" theme added as a new theme option.

How theme is built ?
Webpack config is changed to achieve it. On running yarn run bundle, code will read all the directories in web/pgadmin/static/scss/resources which will be considered as theme dirs, build a separate css for every theme and then create a file named pgadmin.themes.json which will have all the information required.

The patch also fixes RM4173, where there some issue with arrow icons in browser tree.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py. I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4348.part2.patch (30K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4348.part2_v2.patch (31K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Akshay Joshi
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
- The tagline on the dashboard logo isn't readable.

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company

Screenshot 2019-11-11 at 14.59.43.png (6K) Download Attachment
Screenshot 2019-11-11 at 14.58.33.png (43K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Dave,

On Mon, Nov 11, 2019, 20:33 Dave Page <[hidden email]> wrote:
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
I'm not sure why you are not able to see it but I've changed it. Try a python restart.
- The tagline on the dashboard logo isn't readable.
Yes because that's an SVG image. We may need to make it completely from HTML.

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.
There is technical limitation here. To change those grid lines based on theme we need to import variables in JS. I didn't find a way to dynamically load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and is hard coded in JS.

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.
I'll check the color, but AFAIR it's not pure white.

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7
Hi

On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019, 20:33 Dave Page <[hidden email]> wrote:
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
I'm not sure why you are not able to see it but I've changed it. Try a python restart.

I've done a make clean/make bundle, restarted Python, and done a hard reload in the browser to no joy. FYI, I'm running in Chrome 78.0.3904.70 on macOS.
 
- The tagline on the dashboard logo isn't readable.
Yes because that's an SVG image. We may need to make it completely from HTML.

Can we have an alternate image? Maybe if it's served through a flask route and we look for /logo.png?t=dark or something like that to select the image version?
 

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.
There is technical limitation here. To change those grid lines based on theme we need to import variables in JS. I didn't find a way to dynamically load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and is hard coded in JS.

Urgh, OK. We'll need to think about that then.
 

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.
I'll check the color, but AFAIR it's not pure white.

OK, thanks!
 

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi Hackers,

Attached is a patch to address the review comments.

On Mon, Nov 11, 2019 at 9:13 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019, 20:33 Dave Page <[hidden email]> wrote:
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
I'm not sure why you are not able to see it but I've changed it. Try a python restart.

I've done a make clean/make bundle, restarted Python, and done a hard reload in the browser to no joy. FYI, I'm running in Chrome 78.0.3904.70 on macOS.
Screenshot 2019-11-12 at 10.03.59.png
I'm not seeing it. Pulled latest, bundled and restarted. :/

 
- The tagline on the dashboard logo isn't readable.
Yes because that's an SVG image. We may need to make it completely from HTML.

Can we have an alternate image? Maybe if it's served through a flask route and we look for /logo.png?t=dark or something like that to select the image version?
Or better embed the SVG so that we can change colors using CSS. Patch attached. You can tweak $color-brand to change the welcome dashboards blue color. 
 

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.
There is technical limitation here. To change those grid lines based on theme we need to import variables in JS. I didn't find a way to dynamically load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and is hard coded in JS.

Urgh, OK. We'll need to think about that then.
 

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.
I'll check the color, but AFAIR it's not pure white.

OK, thanks!
I didn't find anyone using white color. Could you please share a screenshot ? I've changed the foreground from #ddd to #d4d4d4 to soften a bit.
 

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4348.part3.patch (30K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7
Hi

On Tue, Nov 12, 2019 at 4:59 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is a patch to address the review comments.

On Mon, Nov 11, 2019 at 9:13 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019, 20:33 Dave Page <[hidden email]> wrote:
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
I'm not sure why you are not able to see it but I've changed it. Try a python restart.

I've done a make clean/make bundle, restarted Python, and done a hard reload in the browser to no joy. FYI, I'm running in Chrome 78.0.3904.70 on macOS.
Screenshot 2019-11-12 at 10.03.59.png
I'm not seeing it. Pulled latest, bundled and restarted. :/

So I eventually found that I had a rogue Python process running pgAdmin that somehow got detached from PyCharm. Killed that, restarted, and now it looks good.
 

 
- The tagline on the dashboard logo isn't readable.
Yes because that's an SVG image. We may need to make it completely from HTML.

Can we have an alternate image? Maybe if it's served through a flask route and we look for /logo.png?t=dark or something like that to select the image version?
Or better embed the SVG so that we can change colors using CSS. Patch attached. You can tweak $color-brand to change the welcome dashboards blue color. 

Looks good.
 
 

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.
There is technical limitation here. To change those grid lines based on theme we need to import variables in JS. I didn't find a way to dynamically load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and is hard coded in JS.

Urgh, OK. We'll need to think about that then.
 

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.
I'll check the color, but AFAIR it's not pure white.

OK, thanks!
I didn't find anyone using white color. Could you please share a screenshot ? I've changed the foreground from #ddd to #d4d4d4 to soften a bit.

Attached. It may just be that it looks a little sharp because it's a long line. Maybe we should just make it a darker shade entirely.

Screenshot 2019-11-12 at 09.09.42.png
 
BTW, what was the reason for removing the styling from the scroll bars?

 

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Aditya Toshniwal
Hi,

On Tue, Nov 12, 2019 at 2:47 PM Dave Page <[hidden email]> wrote:
Hi

On Tue, Nov 12, 2019 at 4:59 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is a patch to address the review comments.

On Mon, Nov 11, 2019 at 9:13 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 3:11 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019, 20:33 Dave Page <[hidden email]> wrote:
Hi

That's looking a lot better. I see a couple of issues (screenshots attached):

- The combo box on the query tool toolbar isn't dark.
I'm not sure why you are not able to see it but I've changed it. Try a python restart.

I've done a make clean/make bundle, restarted Python, and done a hard reload in the browser to no joy. FYI, I'm running in Chrome 78.0.3904.70 on macOS.
Screenshot 2019-11-12 at 10.03.59.png
I'm not seeing it. Pulled latest, bundled and restarted. :/

So I eventually found that I had a rogue Python process running pgAdmin that somehow got detached from PyCharm. Killed that, restarted, and now it looks good.
 

 
- The tagline on the dashboard logo isn't readable.
Yes because that's an SVG image. We may need to make it completely from HTML.

Can we have an alternate image? Maybe if it's served through a flask route and we look for /logo.png?t=dark or something like that to select the image version?
Or better embed the SVG so that we can change colors using CSS. Patch attached. You can tweak $color-brand to change the welcome dashboards blue color. 

Looks good.
 
 

A couple of other thoughts:

- The guide lines on the graphs are still too bright. Let's make them the same colour as the graph boarders please.
There is technical limitation here. To change those grid lines based on theme we need to import variables in JS. I didn't find a way to dynamically load SASS variables based on theme.
So I chose color which would work for both dark and black backgrounds and is hard coded in JS.

Urgh, OK. We'll need to think about that then.
 

- The header bar foreground colour and the dividing white line below it seem quite harsh. Are they pure white? They should be softened a little bit.
I'll check the color, but AFAIR it's not pure white.

OK, thanks!
I didn't find anyone using white color. Could you please share a screenshot ? I've changed the foreground from #ddd to #d4d4d4 to soften a bit.

Attached. It may just be that it looks a little sharp because it's a long line. Maybe we should just make it a darker shade entirely.

Screenshot 2019-11-12 at 09.09.42.png

Why can't I see it :/
Maybe it got fixed along with the dark drop down for no limit. Could you please check again.
image.png
 
BTW, what was the reason for removing the styling from the scroll bars?
We had given gray shades to scrollbar which were not clearly visible for some tables. Plus, for systems were scrollbar is not always enabled was showing scrollbar. It should appear only on scroll on those systems.

 

Thanks!

On Mon, Nov 11, 2019 at 1:22 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

As per discussion with Aditya, we have removed customized scroll bars for the time being as they are not clearly visible with some of the components.

On Mon, Nov 11, 2019 at 5:25 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch.
Kindly review.

On Mon, Nov 11, 2019 at 3:42 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Kindly hold on with the patch. Few more changes required per review by [hidden email] .

On Mon, Nov 11, 2019 at 3:07 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch for further improvements in the Dark theme colors.
Gray shades and other colors are changed to identify different components more clearly. Few of the controls were missing the privileges of dark theme, fixed that.
Few dashboard graph related changes.
As suggested, theme related code changes is removed from config.py and moved to miscellaneous under a new package - Themes. Thank you [hidden email] for inputs on that.

Kindly review.

On Mon, Nov 11, 2019 at 3:00 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Mon, Nov 11, 2019 at 2:38 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, Nov 11, 2019 at 7:01 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Dave,

On Thu, Nov 7, 2019 at 7:56 PM Dave Page <[hidden email]> wrote:


On Thu, Nov 7, 2019 at 2:18 PM Dave Page <[hidden email]> wrote:

On Thu, Nov 7, 2019 at 1:25 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Thu, Nov 7, 2019 at 6:39 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the updated patch with few more changes and corrections.
Kindly review.

I've committed a couple of minor tweaks - one to remove a space, e.g.
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now ?'),
is now:
gettext('A page refresh is required to apply the theme. Do you wish to refresh the page now?'),
And another change to fix the word wrapping in the README which was totally different from the rest of the file.

Thanks!

Oh, and do we need all the code in config.py? I really didn't even want a config option in there to turn theming on or off (what's the point?), let alone 20 new lines.
The code is added after the config_local and config_distro is loaded. So, user won't be able to disable it unless he directly changes the config.py.

That is clearly wrong and needs to be fixed. config_local and config_distro should be able to override anything in config.py.

But... why allow the themes to be updated or disabled at all? It's not like a non-developer can add new ones, and it's not a security issue that an administrator might need to control. In fact, it's arguably an accessibility feature, for those whose eyes (like mine) last the day better with a darker theme.

Let's remove it entirely please. I don't see any good reason to have any of that in config.py.
Intention is not to allow disabling the themes, but it's the feature implementation code. I'll move out the code.

Thanks.
 
I'll reduce the code a bit.

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Dave Page-7
Hi

On Tue, Nov 12, 2019 at 9:50 AM Aditya Toshniwal <[hidden email]> wrote:

Attached. It may just be that it looks a little sharp because it's a long line. Maybe we should just make it a darker shade entirely.

Screenshot 2019-11-12 at 09.09.42.png

Why can't I see it :/
Maybe it got fixed along with the dark drop down for no limit. Could you please check again.
image.png

Nope, it's definitely still there:

Screenshot 2019-11-12 at 09.53.02.png

 
BTW, what was the reason for removing the styling from the scroll bars?
We had given gray shades to scrollbar which were not clearly visible for some tables. Plus, for systems were scrollbar is not always enabled was showing scrollbar. It should appear only on scroll on those systems.

And you're working on that? We can't keep the ugly grey scroll bars!

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4348] Theme options in pgAdmin and dark theme

Avin Kavish
For inspiration,

image.png

On Tue, Nov 12, 2019 at 3:25 PM Dave Page <[hidden email]> wrote:
Hi

On Tue, Nov 12, 2019 at 9:50 AM Aditya Toshniwal <[hidden email]> wrote:

Attached. It may just be that it looks a little sharp because it's a long line. Maybe we should just make it a darker shade entirely.

Screenshot 2019-11-12 at 09.09.42.png

Why can't I see it :/
Maybe it got fixed along with the dark drop down for no limit. Could you please check again.
image.png

Nope, it's definitely still there:

Screenshot 2019-11-12 at 09.53.02.png

 
BTW, what was the reason for removing the styling from the scroll bars?
We had given gray shades to scrollbar which were not clearly visible for some tables. Plus, for systems were scrollbar is not always enabled was showing scrollbar. It should appear only on scroll on those systems.

And you're working on that? We can't keep the ugly grey scroll bars!

Thanks!

--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
12