[pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Aditya Toshniwal
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4351.patch (575K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Dave Page-7
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Dave Page-7
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Aditya Toshniwal
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4351.part2.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Dave Page-7
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Aditya Toshniwal


On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[hidden email]> wrote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. 
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Aditya Toshniwal
Hi Hackers,

As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.
Note that, the preference option is same for Close and Reset button.

Kindly review.

On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <[hidden email]> wrote:


On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[hidden email]> wrote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. 
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4351.part3.patch (584K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Akshay Joshi
Hi Aditya

I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch.

On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.
Note that, the preference option is same for Close and Reset button.

Kindly review.

On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <[hidden email]> wrote:


On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[hidden email]> wrote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. 
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Aditya Toshniwal
Hi,

Please find the attached updated patch.

On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch.

On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.
Note that, the preference option is same for Close and Reset button.

Kindly review.

On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <[hidden email]> wrote:


On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[hidden email]> wrote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. 
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"

RM4351.part3_v2.patch (584K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM4351] Confirm before close of properties dialog if changes not saved

Akshay Joshi
Thanks, patch applied.

On Tue, Nov 5, 2019 at 12:46 PM Aditya Toshniwal <[hidden email]> wrote:
Hi,

Please find the attached updated patch.

On Tue, Nov 5, 2019 at 11:01 AM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

I have tested it. Reset functionality not working when preference setting is set to False. Please fix and resend the patch.

On Mon, Nov 4, 2019 at 5:15 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

As discussed, extending the changes to Reset button also. Warning will appear for Reset button now if opted in preferences and changes are not saved.
Note that, the preference option is same for Close and Reset button.

Kindly review.

On Wed, Oct 30, 2019 at 6:24 PM Aditya Toshniwal <[hidden email]> wrote:


On Wed, Oct 30, 2019 at 3:44 PM Dave Page <[hidden email]> wrote:
Hi

On Wed, Oct 30, 2019 at 4:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi,

On Tue, Oct 29, 2019 at 9:01 PM Dave Page <[hidden email]> wrote:
Hi

I just found an, umm, embarrassing issue with this. It asks for the cancel confirmation even when pressing the OK button :-o
Tested all but missed the obvious. Bad miss :/
Attached is the patch to fix the issue. 

Thanks - applied. Should we also warn on Reset? That seems logical to me.
Can be added. Preference option should be common for both Cancel and Reset. Will send an add-on patch for this. 
 

Can you fix that ASAP please?

On Tue, Oct 29, 2019 at 2:35 PM Dave Page <[hidden email]> wrote:
Thanks, applied.

On Tue, Oct 29, 2019 at 6:40 AM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached is the patch to warn the user before closing an unsaved properties dialog.
Additionally, I have added a preference option in Browser->Display where the user can disable this. Default is enabled.
Docs updated.

Kindly review.

--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks and Regards,
Aditya Toshniwal
Sr. Software Engineer | EnterpriseDB India | Pune
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246