[pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Aditya Toshniwal
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

RM5488.patch (19K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Akshay Joshi
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Aditya Toshniwal
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

RM5488_v2.patch (1M) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Akshay Joshi
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Aditya Toshniwal
Hi Hackers,

Attached patch:
1) Fixes the broken explain GUI test case.
2) Displays a tooltip "Click for details..." on hover over explain plan nodes.

Please review.

On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

RM5488.feature.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5488] Tooltip information does not display properly if user check all options under explain analyze

Akshay Joshi
Thanks, patch applied.

On Wed, Jan 20, 2021 at 4:37 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch:
1) Fixes the broken explain GUI test case.
2) Displays a tooltip "Click for details..." on hover over explain plan nodes.

Please review.

On Tue, Jan 12, 2021 at 4:45 PM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Tue, Jan 12, 2021 at 4:08 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Akshay,

Attached is the updated patch. Please review.

On Tue, Jan 12, 2021 at 2:51 PM Akshay Joshi <[hidden email]> wrote:
Hi Aditya

Code looks good to me. Below are the review comments:
  • Copy and Paste not working in the popup.
  • Documentation needs to be updated.

On Mon, Jan 11, 2021 at 4:38 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

Attached patch improves the way explain plan details tooltip for a node is shown. With the change, popup with details will be shown upon clicking a node, and it will remain open until explicitly closed.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246