[pgAdmin][RM5815] Generate script is not working in new window

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin][RM5815] Generate script is not working in new window

Aditya Toshniwal
Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked (with query tool setting "open in new tab" set to true) then it shows a forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can allow pop up and generate the script again.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"

RM5815.patch (4K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin][RM5815] Generate script is not working in new window

Akshay Joshi
Thanks, patch applied.

On Wed, Sep 9, 2020 at 3:19 PM Aditya Toshniwal <[hidden email]> wrote:
Hi Hackers,

If schema diff is opened in a new tab and "Generate script" is clicked (with query tool setting "open in new tab" set to true) then it shows a forever spinner because of pop up blocks.

Attached patch will show an alert message in that case so that the user can allow pop up and generate the script again.

Please review.

--
Thanks,
Aditya Toshniwal
pgAdmin hacker | Sr. Software Engineer | edbpostgres.com
"Don't Complain about Heat, Plant a TREE"


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246