[pgAdmin] RM6098 Manually deleting from table view hangs

Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--

Rahul Shirsat

Senior Software Engineer | EnterpriseDB Corporation.

Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:

Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--

Rahul Shirsat

Senior Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Hi Rahul,

While reviewing the patch, found one observation with deleted records.

1. Selected multiple records and click on delete records.

2. Now unselect or unmark any record. (click on index column cell to unselect the row)

3. Click on the Save data changes button.

4. All selected records get deleted but the unselected records remain in the grid.

5.  After re-executing the filter query that record gets removed from the grid.

Regards,

Nikhil Mohite.

On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <[hidden email]> wrote:

Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:

Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--

Rahul Shirsat

Senior Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

Fixed the above observation. Removed unnecessary code for calling slickgrid delete API.

On Tue, Jan 19, 2021 at 3:30 PM Nikhil Mohite <[hidden email]> wrote:

Hi Rahul,

While reviewing the patch, found one observation with deleted records.

1. Selected multiple records and click on delete records.

2. Now unselect or unmark any record. (click on index column cell to unselect the row)

3. Click on the Save data changes button.

4. All selected records get deleted but the unselected records remain in the grid.

5.  After re-executing the filter query that record gets removed from the grid.

Regards,

Nikhil Mohite.

On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <[hidden email]> wrote:

Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:

Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--

Rahul Shirsat

Senior Software Engineer | EnterpriseDB Corporation.

--

Thanks & Regards

Akshay Joshi

pgAdmin Hacker | Principal Software Architect

EDB Postgres

Mobile: +91 976-788-8246

--

Rahul Shirsat

Senior Software Engineer | EnterpriseDB Corporation.