[pgAdmin] RM6098 Manually deleting from table view hangs

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin] RM6098 Manually deleting from table view hangs

Rahul Shirsat
Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.

RM6098.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin] RM6098 Manually deleting from table view hangs

Akshay Joshi
Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin] RM6098 Manually deleting from table view hangs

nikhil.mohite
Hi Rahul,

While reviewing the patch, found one observation with deleted records.
1. Selected multiple records and click on delete records.
Screenshot 2021-01-19 at 3.05.55 PM.png
2. Now unselect or unmark any record. (click on index column cell to unselect the row)
Screenshot 2021-01-19 at 3.06.04 PM.png
3. Click on the Save data changes button.
4. All selected records get deleted but the unselected records remain in the grid.
Screenshot 2021-01-19 at 3.06.13 PM.png
5.  After re-executing the filter query that record gets removed from the grid.

Regards,
Nikhil Mohite.



On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <[hidden email]> wrote:
Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin] RM6098 Manually deleting from table view hangs

Rahul Shirsat
Fixed the above observation. Removed unnecessary code for calling slickgrid delete API.

On Tue, Jan 19, 2021 at 3:30 PM Nikhil Mohite <[hidden email]> wrote:
Hi Rahul,

While reviewing the patch, found one observation with deleted records.
1. Selected multiple records and click on delete records.
Screenshot 2021-01-19 at 3.05.55 PM.png
2. Now unselect or unmark any record. (click on index column cell to unselect the row)
Screenshot 2021-01-19 at 3.06.04 PM.png
3. Click on the Save data changes button.
4. All selected records get deleted but the unselected records remain in the grid.
Screenshot 2021-01-19 at 3.06.13 PM.png
5.  After re-executing the filter query that record gets removed from the grid.

Regards,
Nikhil Mohite.



On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <[hidden email]> wrote:
Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.

RM6098_v2.patch (964 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin] RM6098 Manually deleting from table view hangs

Akshay Joshi
Thanks, patch applied.

On Tue, Jan 19, 2021 at 8:53 PM Rahul Shirsat <[hidden email]> wrote:
Fixed the above observation. Removed unnecessary code for calling slickgrid delete API.

On Tue, Jan 19, 2021 at 3:30 PM Nikhil Mohite <[hidden email]> wrote:
Hi Rahul,

While reviewing the patch, found one observation with deleted records.
1. Selected multiple records and click on delete records.
Screenshot 2021-01-19 at 3.05.55 PM.png
2. Now unselect or unmark any record. (click on index column cell to unselect the row)
Screenshot 2021-01-19 at 3.06.04 PM.png
3. Click on the Save data changes button.
4. All selected records get deleted but the unselected records remain in the grid.
Screenshot 2021-01-19 at 3.06.13 PM.png
5.  After re-executing the filter query that record gets removed from the grid.

Regards,
Nikhil Mohite.



On Tue, Jan 19, 2021 at 1:41 PM Akshay Joshi <[hidden email]> wrote:
Hi Nikhil

Can you please review it.

On Mon, Jan 18, 2021 at 8:21 PM Rahul Shirsat <[hidden email]> wrote:
Hi Hackers,

Please find the attached patch which resolves the issue of deleting records when the user tries to delete multiple records step by step.

--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246



--
Rahul Shirsat
Senior Software Engineer | EnterpriseDB Corporation.


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246