[pgAdmin4][Patch]: Added basic start up logs for RunTime

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][Patch]: Added basic start up logs for RunTime

Akshay Joshi
Hi Hackers,

I have added basic startup logs for pgAdmin4 RunTime. One log file "pgAdmin4_startup.log" will be created in the home directory (same as we created for python server logs) every time when pgAdmin4 launched.

I have created one singleton class, so that logging is done through multiple files without creating/passing the logger object between multiple files.

Attached is the patch, please review it.   

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246

Runtime_Logger.patch (16K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch]: Added basic start up logs for RunTime

Dave Page-7
Thanks, applied with a couple of tweaks:

- Changed the logfile name to ~/.pgAdmin4.startup.log (for greater consistency with the runtime log).
- Secured the permissions of the logfile as soon as it's created, to avoid key leaks.

On Thu, Sep 13, 2018 at 2:06 PM, Akshay Joshi <[hidden email]> wrote:
Hi Hackers,

I have added basic startup logs for pgAdmin4 RunTime. One log file "pgAdmin4_startup.log" will be created in the home directory (same as we created for python server logs) every time when pgAdmin4 launched.

I have created one singleton class, so that logging is done through multiple files without creating/passing the logger object between multiple files.

Attached is the patch, please review it.   

--
Akshay Joshi
Sr. Software Architect


Phone: +91 20-3058-9517
Mobile: +91 976-788-8246



--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company