[pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

Yogesh Mahajan
Hi,

Please find patch which fixes 15+ issues related to rule - 
1.String literals should not be duplicated

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709

SonarQubeFix12_v1.patch (48K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

Akshay Joshi
Hi Yogesh

Instead of declaring global variables, I would suggest declaring them as a class variable (constants). Make the changes and resend the patch

On Mon, Aug 3, 2020 at 10:40 AM Yogesh Mahajan <[hidden email]> wrote:
Hi,

Please find patch which fixes 15+ issues related to rule - 
1.String literals should not be duplicated

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246

Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][Patch] - SonarQube Issues - 12 (String literals should not be duplicated)

Yogesh Mahajan
Hello,

Please find the attached patch - 


Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


On Mon, Aug 3, 2020 at 12:56 PM Akshay Joshi <[hidden email]> wrote:
Hi Yogesh

Instead of declaring global variables, I would suggest declaring them as a class variable (constants). Make the changes and resend the patch

On Mon, Aug 3, 2020 at 10:40 AM Yogesh Mahajan <[hidden email]> wrote:
Hi,

Please find patch which fixes 15+ issues related to rule - 
1.String literals should not be duplicated

Thanks,
Yogesh Mahajan
QA - Team
EnterpriseDB Corporation

Phone: +91-9741705709


--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Sr. Software Architect
EDB Postgres
Mobile: +91 976-788-8246


SonarQubeFix12_v2.patch (49K) Download Attachment