[pgAdmin4[RM#3948] Fix backform note control style

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4[RM#3948] Fix backform note control style

Murtuza Zabuawala
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_3948.diff (1K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4[RM#3948] Fix backform note control style

Khushboo Vashi
Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.
We need your suggestion on this to improve it as I feel it needs improvement.

Thanks,
Khushboo


On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


Existing_design.png (862K) Download Attachment
Proposed_design.png (866K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4[RM#3948] Fix backform note control style

Chethana Kumar
Hi Khushboo and Murtuza,

I have attached the improved version of the design, please share your views.
A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).

---
Chethana kumar
Existing_design.png



On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <[hidden email]> wrote:
Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.
We need your suggestion on this to improve it as I feel it needs improvement.

Thanks,
Khushboo


On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4[RM#3948] Fix backform note control style

Ashesh Vashi

On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <[hidden email]> wrote:

Hi Khushboo and Murtuza,

I have attached the improved version of the design, please share your views.
A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).
Chethana,

Can you please send the color combination, when the note control is appeared under a subnode control (with white background color)?

-- Thanks, Ashesh 

---
Chethana kumar
Existing_design.png



On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <[hidden email]> wrote:
Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.
We need your suggestion on this to improve it as I feel it needs improvement.

Thanks,
Khushboo


On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4[RM#3948] Fix backform note control style

Chethana Kumar
Ashesh,

It remains same with the white background because the note icon itself enough to grab the attention of the user.
I have attached the design sample as well.

with-patch.png


---
Chethana kumar

On Fri, Feb 1, 2019 at 6:45 PM Ashesh Vashi <[hidden email]> wrote:

On Fri, Feb 1, 2019 at 6:42 PM Chethana Kumar <[hidden email]> wrote:

Hi Khushboo and Murtuza,

I have attached the improved version of the design, please share your views.
A 'note' text should be always be highlighted rather than keeping it muted (faded coloured text).
Chethana,

Can you please send the color combination, when the note control is appeared under a subnode control (with white background color)?

-- Thanks, Ashesh 

---
Chethana kumar
Existing_design.png



On Wed, Jan 30, 2019 at 4:39 PM Khushboo Vashi <[hidden email]> wrote:
Hi Murtuza,

I have reviewed your patch and I feel we need Chethana's suggestion on this.

@ Chethana,

Please have a look the attached screen-shots (Existing_design and Proposed_design). With this patch the Note section design has been changed.
We need your suggestion on this to improve it as I feel it needs improvement.

Thanks,
Khushboo


On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146


--
Chethana Kumar
Principal UI/UX Designer
EnterpriseDB Corporation


The Postgres Database Company

P: +91 86981 57146
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4[RM#3948] Fix backform note control style

Murtuza Zabuawala
In reply to this post by Khushboo Vashi
Hi,

PFA updated patch.


Regards,
Murtuza
 

On Wed, Jan 30, 2019 at 3:52 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the style, changed the background colour and text colour so that it can be readable.

--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_3948_v1.diff (3K) Download Attachment