[pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

Murtuza Zabuawala
Hi,

PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality opens up the saved password list which cause the Backgrid to lose focus from the current cell and causes issue in keyboard navigation.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


RM_4278.diff (590 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

Dave Page-7
Hi

On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality opens up the saved password list which cause the Backgrid to lose focus from the current cell and causes issue in keyboard navigation.

 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

Murtuza Zabuawala
Hi Dave,

Yes, that's is annoying for me too to debug that issue :)

And now setting it "new-password" does not cause the Backgrid to lose focus, As of now I can see the only workaround that worked for me in all browsers, I've tested in latest Chrome/FF & IE11.




On Mon, May 20, 2019 at 2:32 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality opens up the saved password list which cause the Backgrid to lose focus from the current cell and causes issue in keyboard navigation.

 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#4278] Backgrid loses the focus when PasswordCell opens autocomplete suggestion list

Dave Page-7
Hi

OK, well this won't hurt anyway, so patch applied. 

Thanks!

On Mon, May 20, 2019 at 11:53 AM Murtuza Zabuawala <[hidden email]> wrote:
Hi Dave,

Yes, that's is annoying for me too to debug that issue :)

And now setting it "new-password" does not cause the Backgrid to lose focus, As of now I can see the only workaround that worked for me in all browsers, I've tested in latest Chrome/FF & IE11.




On Mon, May 20, 2019 at 2:32 PM Dave Page <[hidden email]> wrote:
Hi

On Mon, May 20, 2019 at 8:01 AM Murtuza Zabuawala <[hidden email]> wrote:
Hi,

PFA minor patch to fix the issue with Backgrid PasswordCell.
In the Backgrid PasswordCell, The browser's autocomplete functionality opens up the saved password list which cause the Backgrid to lose focus from the current cell and causes issue in keyboard navigation.

 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company


--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company