[pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Ganesh Jaybhay
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay

RM5107.patch (13K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for buttons in file manager dialogue

Ganesh Jaybhay
Changed the subject

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Akshay Joshi
In reply to this post by Ganesh Jaybhay
Hi Ganesh

Following are the review comments:
  • Focus is going on Table headers but it is not visible.
  • Need to handle keyboard events on table header for sorting.
  • Add tabindex property for the table rows.
  • Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Murtuza Zabuawala
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <[hidden email]> wrote:
Hi Ganesh

Following are the review comments:
  • Focus is going on Table headers but it is not visible.
  • Need to handle keyboard events on table header for sorting.
  • Add tabindex property for the table rows.
  • Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

RM5107_v3.patch (22K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Akshay Joshi
Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <[hidden email]> wrote:
Hi Ganesh

Following are the review comments:
  • Focus is going on Table headers but it is not visible.
  • Need to handle keyboard events on table header for sorting.
  • Add tabindex property for the table rows.
  • Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Murtuza Zabuawala
Hi Akshay,

Please find a fix for two issues reported by QA team,
- Show focus when the Tab key is pressed
- Pressing the Enter key on C:\ drive does not open it on Windows


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Fri, Jan 31, 2020 at 11:45 AM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <[hidden email]> wrote:
Hi Ganesh

Following are the review comments:
  • Focus is going on Table headers but it is not visible.
  • Need to handle keyboard events on table header for sorting.
  • Add tabindex property for the table rows.
  • Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246

RM_5107_IE11_fix.diff (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAdmin4][RM#5107] Add tab navigation for tabs under explain panel in query tool

Akshay Joshi
Thanks, patch applied.

On Thu, Feb 6, 2020 at 10:30 AM Murtuza Zabuawala <[hidden email]> wrote:
Hi Akshay,

Please find a fix for two issues reported by QA team,
- Show focus when the Tab key is pressed
- Pressing the Enter key on C:\ drive does not open it on Windows


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Fri, Jan 31, 2020 at 11:45 AM Akshay Joshi <[hidden email]> wrote:
Thanks, patch applied.

On Tue, Jan 28, 2020 at 12:01 PM Murtuza Zabuawala <[hidden email]> wrote:
Hi Akshay,

PFA updated patch.


--
Regards,
Murtuza Zabuawala
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company



On Thu, Jan 23, 2020 at 12:39 PM Akshay Joshi <[hidden email]> wrote:
Hi Ganesh

Following are the review comments:
  • Focus is going on Table headers but it is not visible.
  • Need to handle keyboard events on table header for sorting.
  • Add tabindex property for the table rows.
  • Add keyboard events to select the file from the file dialog.

On Tue, Jan 21, 2020 at 6:26 PM Ganesh Jaybhay <[hidden email]> wrote:
Hi Hackers,

Please find the attached minor fix for tab navigation on footer and confirmation dialog buttons from file manager dialogue
Kindly review.

Regards,
Ganesh Jaybhay


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246


--
Thanks & Regards
Akshay Joshi
Sr. Software Architect
EnterpriseDB Software India Private Limited
Mobile: +91 976-788-8246