[pgAmin4][Patch] - Kerberos support for Windows Installer

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[pgAmin4][Patch] - Kerberos support for Windows Installer

Khushboo Vashi
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

Thanks,
Khushboo

Kerberos_win_dep.patch (2K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Dave Page-7
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <[hidden email]> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

IF NOT EXIST "%PGADMIN_QT_DIR%" (
ECHO !PGADMIN_QT_DIR! does not exist.
ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com

Reply | Threaded
Open this post in threaded view
|

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Khushboo Vashi
Hi Dave,

Please find the attached updated patch.

Thanks,
Khushbo

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <[hidden email]> wrote:
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <[hidden email]> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
Fixed. 
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

Fixed. 
IF NOT EXIST "%PGADMIN_QT_DIR%" (
ECHO !PGADMIN_QT_DIR! does not exist.
ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com


kerberos_win_dep_ver1.patch (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [pgAmin4][Patch] - Kerberos support for Windows Installer

Akshay Joshi
Thanks, patch applied.

On Thu, Jan 21, 2021 at 3:46 PM Khushboo Vashi <[hidden email]> wrote:
Hi Dave,

Please find the attached updated patch.

Thanks,
Khushbo

On Thu, Jan 21, 2021 at 3:17 PM Dave Page <[hidden email]> wrote:
Hi

On Thu, Jan 21, 2021 at 7:11 AM Khushboo Vashi <[hidden email]> wrote:
Hi,

Please find the attached patch to add the Kerberos support in the Windows installer script.

A couple of comments:

- The file names should be in lower case in the COPY lines. It will still work of course, but for consistency and style...
Fixed. 
- There's no check that the environment variable is set to a valid value. For others, we have code block like:

Fixed. 
IF NOT EXIST "%PGADMIN_QT_DIR%" (
ECHO !PGADMIN_QT_DIR! does not exist.
ECHO Please install Qt and set the PGADMIN_QT_DIR environment variable.
EXIT /B 1
)
 
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake

EDB: http://www.enterprisedb.com



--
Thanks & Regards
Akshay Joshi
pgAdmin Hacker | Principal Software Architect
EDB Postgres
Mobile: +91 976-788-8246