pgsql: Correct obsolete nbtree page split comment.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Correct obsolete nbtree page split comment.

Peter Geoghegan-4
Correct obsolete nbtree page split comment.

Commit 40dae7ec537, which made the nbtree page split algorithm more
robust, made _bt_insert_parent() only unlock the right child of the
parent page before inserting a new downlink into the parent.  Update a
comment from the Berkeley days claiming that both left and right child
pages are unlocked before the new downlink actually gets inserted.

The claim that it is okay to release both locks early based on Lehman
and Yao's say-so never made much sense.  Lehman and Yao must sometimes
"couple" buffer locks across a pair of internal pages when relocating a
downlink, unlike the corresponding code within _bt_getstack().

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3f34283973a342aa1cb709d6e8f5cea430efcf29

Modified Files
--------------
src/backend/access/nbtree/nbtinsert.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)