pgsql: Defend against leaks into RelationBuildPartitionDesc.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Defend against leaks into RelationBuildPartitionDesc.

Robert Haas-5
Defend against leaks into RelationBuildPartitionDesc.

In normal builds, this isn't very important, because the leaks go
into fairly short-lived contexts, but under CLOBBER_CACHE_ALWAYS,
this can result in leaking hundreds of megabytes into MessageContext,
which probably explains recent failures on hyrax.

This may or may not be the best long-term strategy for dealing
with this leak, but we can change it later if we come up with
something better.  For now, do this to make the buildfarm green
again (hopefully).  Commit 898e5e3290a72d288923260143930fb32036c00c
seems to have exacerbated this problem for reasons that are not
quite clear, but I don't believe it's actually the cause.

Discussion: http://postgr.es/m/CA+TgmoY3bRmGB6-DUnoVy5fJoreiBJ43rwMrQRCdPXuKt4Ykaw@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2455ab48844c90419714e27eafd235a85de23232

Modified Files
--------------
src/backend/partitioning/partdesc.c | 20 +++++++++++++++++++-
1 file changed, 19 insertions(+), 1 deletion(-)