pgsql: Disallow a digit as the first character of a variable name in pg

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Disallow a digit as the first character of a variable name in pg

Tom Lane-2
Disallow a digit as the first character of a variable name in pgbench.

The point of this restriction is to avoid trying to substitute variables
into timestamp literal values, which may contain strings like '12:34'.

There is a good deal more that should be done to reduce pgbench's
tendency to substitute where it shouldn't.  But this is sufficient to
solve the case complained of by Jaime Soler, and it's simple enough
to back-patch.

Back-patch to v11; before commit 9d36a3866, pgbench had a slightly
different definition of what a variable name is, and anyway it seems
unwise to change long-stable branches for this.

Fabien Coelho

Discussion: https://postgr.es/m/alpine.DEB.2.22.394.2006291740420.805678@pseudo

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6b045ca6cce01f1512af3438a8d4db4dc83b2d07

Modified Files
--------------
doc/src/sgml/ref/pgbench.sgml |  2 +-
src/bin/pgbench/pgbench.c     | 32 +++++++++++++++++++++++---------
2 files changed, 24 insertions(+), 10 deletions(-)