pgsql: Don't remove surplus columns from GROUP BY for inheritance paren

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Don't remove surplus columns from GROUP BY for inheritance paren

David Rowley-4
Don't remove surplus columns from GROUP BY for inheritance parents

d4c3a156c added code to remove columns that were not part of a table's
PRIMARY KEY constraint from the GROUP BY clause when all the primary key
columns were present in the group by.  This is fine to do since we know
that there will only be one row per group coming from this relation.
However, the logic failed to consider inheritance parent relations.  These
can have child relations without a primary key, but even if they did, they
could duplicate one of the parent's rows or one from another child
relation.  In this case, those additional GROUP BY columns are required.

Fix this by disabling the optimization for inheritance parent tables.
In v11 and beyond, partitioned tables are fine since partitions cannot
overlap and before v11 partitioned tables could not have a primary key.

Reported-by: Manuel Rigger
Discussion: http://postgr.es/m/CA+u7OA7VLKf_vEr6kLF3MnWSA9LToJYncgpNX2tQ-oWzYCBQAw@...
Backpatch-through: 9.6

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/232019b79229db7a438f00f358d86659fbd6fcb9

Modified Files
--------------
src/backend/optimizer/plan/planner.c     |  8 ++++++++
src/test/regress/expected/aggregates.out | 24 +++++++++++++++++++++++-
src/test/regress/sql/aggregates.sql      | 10 +++++++++-
3 files changed, 40 insertions(+), 2 deletions(-)