pgsql: Drop slot's LWLock before returning from SaveSlotToPath()

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Drop slot's LWLock before returning from SaveSlotToPath()

Peter Eisentraut-3
Drop slot's LWLock before returning from SaveSlotToPath()

When SaveSlotToPath() is called with elevel=LOG, the early exits didn't
release the slot's io_in_progress_lock.

This could result in a walsender being stuck on the lock forever.  A
possible way to get into this situation is if the offending code paths
are triggered in a low disk space situation.

Author: Pavan Deolasee <[hidden email]>
Reported-by: Craig Ringer <[hidden email]>
Discussion: https://www.postgresql.org/message-id/flat/56a138c5-de61-f553-7e8f-6789296de785%402ndquadrant.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/49bf81536e242f079bfbce6e8f95f53f18207dd5

Modified Files
--------------
src/backend/replication/slot.c | 10 ++++++++++
1 file changed, 10 insertions(+)