pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

Noah Misch-2
Fail pgwin32_message_to_UTF16() for SQL_ASCII messages.

The function had been interpreting SQL_ASCII messages as UTF8, throwing
an error when they were invalid UTF8.  The new behavior is consistent
with pg_do_encoding_conversion().  This affects LOG_DESTINATION_STDERR
and LOG_DESTINATION_EVENTLOG, which will send untranslated bytes to
write() and ReportEventA().  On buildfarm member bowerbird, enabling
log_connections caused an error whenever the role name was not valid
UTF8.  Back-patch to 9.4 (all supported versions).

Discussion: https://postgr.es/m/20190512015615.GD1124997@...

Branch
------
REL9_4_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/08e3fd96f70a711b4d19927d792dde4a04672c15

Modified Files
--------------
src/backend/utils/mb/mbutils.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)