pgsql: Fix assorted header files that failed to compile standalone.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fix assorted header files that failed to compile standalone.

Tom Lane-2
Fix assorted header files that failed to compile standalone.

We have a longstanding project convention that all .h files should
be includable with no prerequisites other than postgres.h.  This is
tested/relied-on by cpluspluscheck.  However, cpluspluscheck has not
historically been applied to most headers outside the src/include
tree, with the predictable consequence that some of them don't work.
Fix that, usually by adding missing #include dependencies.

The change in printf_hack.h might require some explanation: without
it, my C++ compiler whines that the function is unused.  There's
not so many call sites that "inline" is going to cost much, and
besides all the callers are in test code that we really don't care
about the size of.

There's no actual bugs being fixed here, so I see no need to back-patch.

Discussion: https://postgr.es/m/b517ec3918d645eb950505eac8dd434e@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7640f9312321ceba2af61f7017da7e64f0f7b667

Modified Files
--------------
src/bin/pg_waldump/rmgrdesc.h                | 1 +
src/bin/psql/crosstabview.h                  | 2 ++
src/interfaces/ecpg/ecpglib/ecpglib_extern.h | 1 +
src/interfaces/ecpg/test/printf_hack.h       | 2 +-
src/interfaces/libpq/fe-gssapi-common.h      | 5 +++++
src/pl/plperl/plperl_helpers.h               | 3 +++
src/pl/plpython/plpy_elog.h                  | 2 ++
src/pl/plpython/plpy_resultobject.h          | 2 ++
src/pl/plpython/plpy_spi.h                   | 2 ++
src/pl/plpython/plpy_subxactobject.h         | 2 ++
src/pl/plpython/plpy_typeio.h                | 2 ++
src/pl/plpython/plpy_util.h                  | 2 ++
src/pl/plpython/plpython.h                   | 3 ++-
13 files changed, 27 insertions(+), 2 deletions(-)