pgsql: Fix dependency handling at swap phase of REINDEX CONCURRENTLY

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fix dependency handling at swap phase of REINDEX CONCURRENTLY

Michael Paquier-2
Fix dependency handling at swap phase of REINDEX CONCURRENTLY

When swapping the dependencies of the old and new indexes, the code has
been correctly switching all links in pg_depend from the old to the new
index for both referencing and referenced entries.  However it forgot
the fact that the new index may itself have existing entries in
pg_depend, like references to the parent table attributes.  This
resulted in duplicated entries in pg_depend after running REINDEX
CONCURRENTLY.

Fix this problem by removing any existing entries in pg_depend for the
new index before switching the dependencies of the old index to the new
one.  More regression tests are added to check the consistency of
entries in pg_depend for indexes, including partitions.

Author: Michael Paquier
Discussion: https://postgr.es/m/20191025064318.GF8671@...
Backpatch-through: 12

Branch
------
REL_12_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5e5f32284d691d0be71d6859c1de9b0367b26584

Modified Files
--------------
src/backend/catalog/index.c                |   6 +-
src/test/regress/expected/create_index.out | 126 +++++++++++++++++++++++++++++
src/test/regress/sql/create_index.sql      |  54 +++++++++++++
3 files changed, 185 insertions(+), 1 deletion(-)