pgsql: Fix for dropped columns in a partitioned table's default partiti

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fix for dropped columns in a partitioned table's default partiti

Álvaro Herrera
Fix for dropped columns in a partitioned table's default partition

We forgot to map column numbers to/from the default partition for
various operations, leading to valid cases failing with spurious
errors, such as
ERROR:  attribute N of type some_partition has been dropped

It was also possible that the search for conflicting rows in the default
partition when attaching another partition would fail to detect some.
Secondarily, it was also possible that such a search should be skipped
(because the constraint was implied) but wasn't.

Fix all this by mapping column numbers when necessary.

Reported by: Daniel Wilches
Author: Amit Langote
Discussion: https://postgr.es/m/15873-8c61945d6b3ef87c@...

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/23cccb17fe0bbb5df86780da5c346cc060c21421

Modified Files
--------------
src/backend/commands/tablecmds.c           |  7 +++++++
src/backend/partitioning/partbounds.c      | 24 +++++++++++++++++++-----
src/test/regress/expected/alter_table.out  |  9 ++++++++-
src/test/regress/expected/create_table.out | 14 ++++++++++++++
src/test/regress/sql/alter_table.sql       |  9 ++++++++-
src/test/regress/sql/create_table.sql      | 14 ++++++++++++++
6 files changed, 70 insertions(+), 7 deletions(-)