pgsql: Fix race in test of pg_switch_wal().

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Fix race in test of pg_switch_wal().

Noah Misch-2
Fix race in test of pg_switch_wal().

The test failed when something added WAL between pg_switch_wal() and
pg_current_wal_lsn(), seen on buildfarm members hornet and sungazer.
Fix v10, v9.6 and v9.5 by making this code mirror its v13+ counterpart.
v12 and v11 lack a counterpart.

Branch
------
REL9_5_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/6a7a5fce9a7421cc0e07341921787f55a814249b

Modified Files
--------------
src/test/recovery/t/020_archive_status.pl | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

Reply | Threaded
Open this post in threaded view
|

Re: pgsql: Fix race in test of pg_switch_wal().

Michael Paquier-2
On Mon, Sep 14, 2020 at 06:19:38AM +0000, Noah Misch wrote:
> Fix race in test of pg_switch_wal().
>
> The test failed when something added WAL between pg_switch_wal() and
> pg_current_wal_lsn(), seen on buildfarm members hornet and sungazer.
> Fix v10, v9.6 and v9.5 by making this code mirror its v13+ counterpart.
> v12 and v11 lack a counterpart.

Thanks Noah for that, I did not notice those buildfarm failures:
https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=hornet&dt=2020-07-24%2010%3A24%3A56

It is fine to ping me or just to begin a thread if there is a problem,
I would have taken care of it.

Thanks,
--
Michael

signature.asc (849 bytes) Download Attachment