pgsql: Further fixes for CREATE TABLE LIKE: cope with self-referential

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

pgsql: Further fixes for CREATE TABLE LIKE: cope with self-referential

Tom Lane-2
Further fixes for CREATE TABLE LIKE: cope with self-referential FKs.

Commit 502898192 was too careless about the order of execution of the
additional ALTER TABLE operations generated by expandTableLikeClause.
It just stuck them all at the end, which seems okay for most purposes.
But it falls down in the case where LIKE is importing a primary key
or unique index and the outer CREATE TABLE includes a FOREIGN KEY
constraint that needs to depend on that index.  Weird as that is,
it used to work, so we ought to keep it working.

To fix, make parse_utilcmd.c insert LIKE clauses between index-creation
and FK-creation commands in the transformed list of commands, and change
utility.c so that the commands generated by expandTableLikeClause are
executed immediately not at the end.  One could imagine scenarios where
this wouldn't work either; but currently expandTableLikeClause only
makes column default expressions, CHECK constraints, and indexes, and
this ordering seems fine for those.

Per bug #16730 from Sofoklis Papasofokli.  Like the previous patch,
back-patch to all supported branches.

Discussion: https://postgr.es/m/16730-b902f7e6e0276b30@...

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/c690ebbefa3394b67ceb1ba913590d873ad40355

Modified Files
--------------
src/backend/parser/parse_utilcmd.c              | 27 +++++++++++++++++++-----
src/backend/tcop/utility.c                      | 28 ++++++++++++-------------
src/test/regress/expected/create_table_like.out | 16 ++++++++++++++
src/test/regress/sql/create_table_like.sql      |  5 +++++
4 files changed, 56 insertions(+), 20 deletions(-)